AfterShip
Add disposable emails
Adding domains from https://github.com/disposable/disposable-email-domains. Found this while searching for missing domains from email-fake.com.
@rynmccrmck Thanks for the PR, disposable domains data will be confirmed in the near future, I will also track whether the source repo will be updated, if the data is verified to be OK, I will merge this PR
Pull Request Test Coverage Report for Build 2907700349
- 0 of 0 changed or added relevant lines in 0 files are covered.
- 4 unchanged lines in 2 files lost coverage.
- Overall coverage remained the same at 85.082%
| Files with Coverage Reduction | New Missed Lines | % |
|---|---|---|
| smtp.go | 2 | 84.62% |
| verifier.go | 2 | 74.8% |
| <!-- | Total: | 4 |
| Totals | |
|---|---|
| Change from base Build 2414430456: | 0.0% |
| Covered Lines: | 519 |
| Relevant Lines: | 610 |
💛 - Coveralls
@rynmccrmck Thanks for the PR, disposable domains data will be confirmed in the near future, I will also track whether the source repo will be updated, if the data is verified to be OK, I will merge this PR
Thanks @lryong, anything I can do to help verify this one? If no timelines we can just fork - thank you!
@lryong thanks for review - I just realized that one of the sources.txt is now missing (and why were seeing so many subtractions to free domains). I'll see what I can do and update.
@lryong thanks for review - I just realized that one of the sources.txt is now missing (and why were seeing so many subtractions to free domains). I'll see what I can do and update.
Actually this is free domains being renamed to disposable. If you have any opinion on this please let me know.
@rynmccrmck Thank you for following up on this issue, I double checked your PR and it seems that the data source you provided is not widely recognized. In order to provide a more reliable data source, we are not accepting your PR for now, but we are considering to provide an interface for users to add custom disposable domain or free domain, if you are interested, you are welcome to propose a PR as well!
@lryong IMHO, it's no possible to cover all scenarios in one repo. So it'd will be better to offer a way to load the custom data source, and only maintain minimize data source in the repo.
