email-verifier icon indicating copy to clipboard operation
email-verifier copied to clipboard
verified publisher icon AfterShip

Add support for configurable timeouts in SMTP verification

Open eos175 opened this issue 1 year ago • 3 comments

eos175 avatar Jan 28 '24 20:01 eos175

Thanks for your PR @eos175

lryong avatar Jan 31 '24 08:01 lryong

@eos175 I see that make lint in your PR didn't pass, can you please check it again? you can do it in email-verifier root path directly, Thanks.

lryong avatar Jan 31 '24 08:01 lryong

@lryong I wasn't able to replicate the result of golangci-lint, but it seems to be related to the smtpTimeout = 30 * time.Second unused variable. I believe it should pass now.

eos175 avatar Jan 31 '24 22:01 eos175