kmscon icon indicating copy to clipboard operation
kmscon copied to clipboard
verified publisher icon Aetf

Fix systemd monitor initialization

Open Vogtinator opened this issue 10 months ago • 4 comments

monitor_sd_init needs to get a pointer to struct uterm_sd_mon to be able to initialize it. Previously its contents were never initialized.

Vogtinator avatar Feb 28 '25 14:02 Vogtinator

Before this fix, there was 100% CPU use after logout because handle_sd_event didn't read pending events.

Vogtinator avatar Feb 28 '25 14:02 Vogtinator

This broke in 61236ed39762cd03f2ea8c112b2cc9951a6e982d ("Clean up monitors")

CC @michael-oberpriller

Vogtinator avatar Feb 28 '25 14:02 Vogtinator

Thanks for fixing this, but I will be making a new PR that reverts the broken commits since they did not work as expected.

michael-oberpriller avatar Mar 02 '25 16:03 michael-oberpriller

Ok! I'll leave this open until the other PR is merged.

Vogtinator avatar Mar 03 '25 08:03 Vogtinator

Are both needed?

hustlerone avatar May 15 '25 10:05 hustlerone

Are both needed?

No, either of them will fix that specific issue.

Vogtinator avatar May 15 '25 10:05 Vogtinator

Superseded by #105

Vogtinator avatar May 16 '25 07:05 Vogtinator