[Heck/Noodle] Map has several points where visuals should be, completely gone or incorrect

[Provini]

Describe the bug A clear and concise description of what the bug is.

In the map Someone Else's Hat in version 1.39.1 there are various visual elements gone.

There's also errors from Heck and Noodle. (There are a lot of these! This is only a couple examples.)

Edit: I've listed more examples and logs at the bottom of the post!

[ERROR @ 13:24:46 | Heck] Could not parse custom data for custom event [AnimateTrack] at [0]
[ERROR @ 13:24:46 | Heck] System.InvalidOperationException: Could not find track [fire].
[ERROR @ 13:24:46 | Heck]   at Heck.Animation.AnimationExtensions.GetNullableTrackArray (CustomJSONData.CustomBeatmap.CustomData customData, System.Collections.Generic.Dictionary`2[TKey,TValue] beatmapTracks, System.String name) [0x0006c] in <ae759c6ef8a34c17990f91f953f7f786>:0 
[ERROR @ 13:24:46 | Heck]   at Heck.Animation.AnimationExtensions.GetTrackArray (CustomJSONData.CustomBeatmap.CustomData customData, System.Collections.Generic.Dictionary`2[TKey,TValue] beatmapTracks, System.String name) [0x00000] in <ae759c6ef8a34c17990f91f953f7f786>:0 
[ERROR @ 13:24:46 | Heck]   at Heck.Animation.AnimationExtensions.GetTrackArray (CustomJSONData.CustomBeatmap.CustomData customData, System.Collections.Generic.Dictionary`2[TKey,TValue] beatmapTracks, System.Boolean v2) [0x00000] in <ae759c6ef8a34c17990f91f953f7f786>:0 
[ERROR @ 13:24:46 | Heck]   at Heck.HeckCoroutineEventData..ctor (CustomJSONData.CustomBeatmap.CustomEventData customEventData, System.Collections.Generic.Dictionary`2[TKey,TValue] pointDefinitions, System.Collections.Generic.Dictionary`2[TKey,TValue] beatmapTracks, System.Boolean v2) [0x00077] in <ae759c6ef8a34c17990f91f953f7f786>:0 
[ERROR @ 13:24:46 | Heck]   at Heck.CustomDataDeserializer.DeserializeCustomEvents () [0x00063] in <ae759c6ef8a34c17990f91f953f7f786>:0 

[ERROR @ 13:25:06 | NoodleExtensions] Could not parse custom data for custom event [AssignTrackParent] at [0]
[ERROR @ 13:25:06 | NoodleExtensions] System.InvalidOperationException: Could not find track [fire].
[ERROR @ 13:25:06 | NoodleExtensions]   at Heck.Animation.AnimationExtensions.GetNullableTrackArray (CustomJSONData.CustomBeatmap.CustomData customData, System.Collections.Generic.Dictionary`2[TKey,TValue] beatmapTracks, System.String name) [0x0006c] in <ae759c6ef8a34c17990f91f953f7f786>:0 
[ERROR @ 13:25:06 | NoodleExtensions]   at Heck.Animation.AnimationExtensions.GetTrackArray (CustomJSONData.CustomBeatmap.CustomData customData, System.Collections.Generic.Dictionary`2[TKey,TValue] beatmapTracks, System.String name) [0x00000] in <ae759c6ef8a34c17990f91f953f7f786>:0 
[ERROR @ 13:25:06 | NoodleExtensions]   at NoodleExtensions.NoodleParentTrackEventData..ctor (CustomJSONData.CustomBeatmap.CustomData customData, System.Collections.Generic.Dictionary`2[TKey,TValue] beatmapTracks, System.Boolean v2) [0x00022] in <e068ebb9618b4a10b7e67b0811cc9619>:0 
[ERROR @ 13:25:06 | NoodleExtensions]   at NoodleExtensions.CustomDataDeserializer.DeserializeCustomEvents () [0x00074] in <e068ebb9618b4a10b7e67b0811cc9619>:0 

To Reproduce Steps to reproduce the behavior:

1. Launch 1.39.1 (possibly older versions are affected too)
2. Play "Someone Elses Hat"
3. Observe missing visual elements compared to the video below
4. See errors from Heck and Noodle

Expected behavior (See this video of the intended visuals)

Additional context Add any other context about the problem here. PLEASE ATTACH YOUR LOG FILE (Beat Saber\Logs_latest.log) OR YOUR ISSUE MAY NOT BE LOOKED AT.

_latest.log (another log attached below in the edit)

Edit: There are other maps that had errors present as well

I've attached a log that has blocks of errors for following songs:

• acloudyskye - Storyteller (missing lasers in the intro)

• acloudyskye - Heliov (one error, haven't noticed anything visual different)

• acloudyskye - Vanishing Point (lots of errors, missing helix walls on Lawless(X+) difficulty)

• acloudyskye - Thief! (some chroma regex errors which may or may not be legitimate errors as no visible seen difference)

• _latest.log

• Superluminal

  • This map throws errors on 1.39.1, causing some visuals to not spawn at ~1:50. Attached log below.
  • Additionally on this particular map, there are issues affecting all other BeatSaber versions including 1.29.1 when using updated mods
    • Rotating Vortex at 1:18 visually breaks on Heck v1.7.2+
    • Exploding Star at 1:50 visually breaks on NoodleExtensions v1.7.9+
  • _latest.log

• A relatively more recent map Change of scene

  • ~~This map is missing the intro screen that says "Change of scene" in BS v1.39.1+~~ Upon closer inspection, this seems related to the shaderKeywords issue as the intro screen is there, just very dark due to said known issue. Map works fine otherwise.

Pardon for all the edits!

[QKCQW]

[Provini]

I tested your map above and yeah it is indeed missing some walls and oddly enough no errors. Regardless since it wasn't provided, I'll provide a log for the song above.

_latest.log

https://beatsaver.com/maps/dd1d

[Aeroluna]

Missing walls seems to be because of a change in BS v1.39.1 that outright prevents loading of negative size/duration walls. This is combined with a bug in CJD that prevented SongCore from patching the related method. This is fixed in https://github.com/Aeroluna/CustomJSONData/commit/913913e8b7e8ad0fe28b4370d410ac936410dc01 to allow negative size/duration walls

[Provini]

Does this include the issues I mentioned for Superluminal, which I know is a bit different than issue reported in the original post, that broke above a certain mod version regardless of Beat Saber version, or should I open a new issue regarding that?

[Provini]

Since this was reopened, I thought it would be helpful to post updates after CustomJSONData was updated, along with more accurate info.

• Someone Else's Hat

  • Everything visually seems correct!

• acloudyskye - Storyteller

  • Still missing lasers in the intro.
  • Also missing the moving side walls at 1:34-1:55
    • Apparently both of these broke a loooong time ago. v1.29.1, worked with _Heck v1.4.8 but broke in _Heck v1.4.11. Further tested _Heck v1.4.9 in BS 1.31.0 and it was broke there. Conclusion is that it broke in Heck v1.4.9+
  • Errors in attached log, related to Quaternion and Vector3 modifier points
  • Findings: This issue seemed to be caused by a 0 being set where easings should be for some position and scale properties. I assume this was previously allowed in older versions. Removing this unnecessary value in the beatmap data removed the errors and fixed the visuals.
    • It seems multiple older maps have a similar issue, where a number was somehow set for the easings value, and Heck v1.4.8 seemed to ignore the invalid value. In up to date versions, in all cases, removing the invalid value restored intended visuals.

• acloudyskye - Heliov

  • Error gone and everything visually seems correct

• acloudyskye - Vanishing Point

  • Helix Walls are back! Everything visually seems correct
  • Determined existing errors existed on map release, disregard

• acloudyskye - Thief!

  • Everything visually seems correct
  • Determined regex errors existed on map release, disregard

• Superluminal

  • No change, to reiterate:
    • Rotating Vortex at 1:18 visually breaks on Heck v1.7.2+, regardless of BS version
    • Exploding Star at 1:50 visually breaks on NoodleExtensions v1.7.9+, regardless of BS version
    • BS v1.39.1 missing various visuals between 1:50-1:54. Appears in 1.40.0.
  • Errors in attached log, missing track errors only occur on v1.39.1 (not on v1.40.0)

• Change of scene

  • I was wrong in the OP and wasn't the shaderKeywords issue (Woops!)
  • Intro visually now seems correct

Edit: Superluminal errors missing in log. Reattached. Edit 2: Storyteller error cause added. Edit 3: I hyperlinked the wrong map for Storyteller woops. Fixed now ;-;

_latest.log