charon icon indicating copy to clipboard operation
charon copied to clipboard

Improve comments heuristic

Open Nadrieril opened this issue 1 year ago • 6 comments

Fixes #388.

Nadrieril avatar Oct 01 '24 08:10 Nadrieril

FYI, just gave this a quick try, and I don't seem to be receiving the comments at all anymore (or at least, the one I noticed had a problem)

msprotz avatar Oct 01 '24 16:10 msprotz

Yeah I marked it as draft because it doesn't work for complex cases such as destructuring or assert! that you test in Eurydice

Nadrieril avatar Oct 01 '24 22:10 Nadrieril

This seems to be rotting. @Nadrieril do you have any plan for this PR?

sonmarcho avatar Nov 05 '24 08:11 sonmarcho

I was hoping to get back to it when higher-priority items are done, but tbf I don't know how to go about this. The few heuristics I tried don't work and the last idea I had required an important change to the visitors library we're using (so we can hold on to borrows while visiting)

Nadrieril avatar Nov 05 '24 08:11 Nadrieril

Is no one else in the Rust ecosystem doing this? (Retaining inline comments.)

Should this be a discussion with upstream Rustc to add more support in the compiler itself?

msprotz avatar Nov 05 '24 16:11 msprotz

I don't know of anyone else doing that no

Nadrieril avatar Nov 05 '24 17:11 Nadrieril