Vitalii Koshura

Results 402 comments of Vitalii Koshura

According to the comparation table in #5064 , the best tool to use is `WiX Toolset`: https://wixtoolset.org/

@CharlieFenton, could you please take a look?

At first, this is a 3rdparty solution. Second, it works on Windows only, as far as I see on the website. So this doesn't really fulfill our requirements.

@KLiKzg, thank you for your feedback. As you can see, this ticket was open more that 6 years ago. This is basically an idea of what can be done by...

@Tanya1515, thank you for your PR. Before we can start review, test and discuss this approach, please fix the falling CI flows. Thank you in advance.

@Tanya1515, code coverage is not important and can be ignored. I'll take a look at the code at the beginning of the next week. Thank you for your PR!

Hello @Tanya1515, sorry for the delay. We were busy releasing a new version of BOINC. I plan to review and test your PR during next couple of weeks.

Closing this in favor of #5757 that contains a better approach of docker detection.

@computezrmle, please fix the failed build. Thank you

> Is it caused by a missing entry in win_build\vcpkg_3rdparty_dependencies.vcxproj? This was an unrelated issue, now fixed by build rerun. Others are still here, so please fix them