adyen-web icon indicating copy to clipboard operation
adyen-web copied to clipboard

adds online banking component for cz and sk

Open m1aw opened this issue 2 years ago • 4 comments

Summary

This PR adds a new OnlineBanking component. This is an issuer list component.

The IssuerList was modified to additionally display a disclaimer that ToS will be accepted upon continuation. This change was made to IssuerList since it might be reused for other components in the future, and seemed generic enough.

There is now also an interpolation function to help place links, or other html elements / react elements, into a string that comes from the translations files. For this we use the %# delimiter.

Additionally CZ and SK currencies where added to the playground.

Tested scenarios

It was tested that the issuer list was rendering and redirecting on the playground.

Fixed issue:

m1aw avatar Jul 06 '22 15:07 m1aw

This pull request introduces 1 alert when merging 0321e2c4e6d00fe034a3c63c4425087649290054 into 58da80c8b21475201a03cd83b222de209224cc7b - view on LGTM.com

new alerts:

  • 1 for Ineffective parameter type

lgtm-com[bot] avatar Jul 22 '22 09:07 lgtm-com[bot]

Size Change: +6.89 kB (+1%)

Total Size: 811 kB

Filename Size Change
packages/lib/dist/adyen.js 216 kB +1.51 kB (+1%)
packages/lib/dist/cjs/index.js 184 kB +1.58 kB (+1%)
packages/lib/dist/es.modern/ar.js 4.61 kB +69 B (+2%)
packages/lib/dist/es.modern/cs-CZ.js 4.13 kB +58 B (+1%)
packages/lib/dist/es.modern/da-DK.js 3.74 kB +54 B (+1%)
packages/lib/dist/es.modern/de-DE.js 4.04 kB +54 B (+1%)
packages/lib/dist/es.modern/el-GR.js 5.13 kB +90 B (+2%)
packages/lib/dist/es.modern/es-ES.js 3.79 kB +61 B (+2%)
packages/lib/dist/es.modern/fi-FI.js 3.83 kB +47 B (+1%)
packages/lib/dist/es.modern/fr-FR.js 3.98 kB +61 B (+2%)
packages/lib/dist/es.modern/hr-HR.js 3.91 kB +56 B (+1%)
packages/lib/dist/es.modern/hu-HU.js 4.1 kB +62 B (+2%)
packages/lib/dist/es.modern/index.js 96 kB +308 B (0%)
packages/lib/dist/es.modern/it-IT.js 3.79 kB +56 B (+2%)
packages/lib/dist/es.modern/ja-JP.js 4.56 kB +66 B (+1%)
packages/lib/dist/es.modern/ko-KR.js 4.16 kB +55 B (+1%)
packages/lib/dist/es.modern/nl-NL.js 3.81 kB +56 B (+1%)
packages/lib/dist/es.modern/no-NO.js 3.73 kB +50 B (+1%)
packages/lib/dist/es.modern/pl-PL.js 4.17 kB +61 B (+1%)
packages/lib/dist/es.modern/pt-BR.js 3.81 kB +57 B (+2%)
packages/lib/dist/es.modern/pt-PT.js 3.94 kB +53 B (+1%)
packages/lib/dist/es.modern/ro-RO.js 4.03 kB +56 B (+1%)
packages/lib/dist/es.modern/ru-RU.js 4.83 kB +75 B (+2%)
packages/lib/dist/es.modern/sk-SK.js 4.17 kB +65 B (+2%)
packages/lib/dist/es.modern/sl-SI.js 3.82 kB +70 B (+2%)
packages/lib/dist/es.modern/sv-SE.js 3.76 kB +49 B (+1%)
packages/lib/dist/es.modern/zh-CN.js 4.07 kB +71 B (+2%)
packages/lib/dist/es.modern/zh-TW.js 4.22 kB +66 B (+2%)
packages/lib/dist/es/ar.js 4.61 kB +69 B (+2%)
packages/lib/dist/es/cs-CZ.js 4.13 kB +58 B (+1%)
packages/lib/dist/es/da-DK.js 3.74 kB +54 B (+1%)
packages/lib/dist/es/de-DE.js 4.04 kB +54 B (+1%)
packages/lib/dist/es/el-GR.js 5.13 kB +90 B (+2%)
packages/lib/dist/es/es-ES.js 3.79 kB +61 B (+2%)
packages/lib/dist/es/fi-FI.js 3.83 kB +47 B (+1%)
packages/lib/dist/es/fr-FR.js 3.98 kB +61 B (+2%)
packages/lib/dist/es/hr-HR.js 3.91 kB +56 B (+1%)
packages/lib/dist/es/hu-HU.js 4.1 kB +62 B (+2%)
packages/lib/dist/es/index.js 112 kB +452 B (0%)
packages/lib/dist/es/it-IT.js 3.79 kB +56 B (+2%)
packages/lib/dist/es/ja-JP.js 4.56 kB +66 B (+1%)
packages/lib/dist/es/ko-KR.js 4.16 kB +55 B (+1%)
packages/lib/dist/es/nl-NL.js 3.81 kB +56 B (+1%)
packages/lib/dist/es/no-NO.js 3.73 kB +50 B (+1%)
packages/lib/dist/es/pl-PL.js 4.17 kB +61 B (+1%)
packages/lib/dist/es/pt-BR.js 3.81 kB +57 B (+2%)
packages/lib/dist/es/pt-PT.js 3.94 kB +53 B (+1%)
packages/lib/dist/es/ro-RO.js 4.03 kB +56 B (+1%)
packages/lib/dist/es/ru-RU.js 4.83 kB +75 B (+2%)
packages/lib/dist/es/sk-SK.js 4.17 kB +65 B (+2%)
packages/lib/dist/es/sl-SI.js 3.82 kB +70 B (+2%)
packages/lib/dist/es/sv-SE.js 3.76 kB +49 B (+1%)
packages/lib/dist/es/zh-CN.js 4.07 kB +71 B (+2%)
packages/lib/dist/es/zh-TW.js 4.22 kB +66 B (+2%)

compressed-size-action

github-actions[bot] avatar Jul 22 '22 10:07 github-actions[bot]

This pull request introduces 1 alert when merging e264acc6a6fb94e9c44af9fd50d07da533618ffc into 58da80c8b21475201a03cd83b222de209224cc7b - view on LGTM.com

new alerts:

  • 1 for Ineffective parameter type

lgtm-com[bot] avatar Jul 22 '22 10:07 lgtm-com[bot]

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

sonarqubecloud[bot] avatar Aug 15 '22 12:08 sonarqubecloud[bot]