adyen-react-native icon indicating copy to clipboard operation
adyen-react-native copied to clipboard

dismiss dialog on hot reload

Open pinpong opened this issue 2 years ago • 2 comments

Improved developer experience by dismissing the pending dialog fragment on hot reload.

How to proof:

  1. Open the example app and open e.g. klarna
  2. close the webview
  3. hot reload
  4. the dialog is no closable because the js bridge was destroyed

pinpong avatar Apr 26 '23 19:04 pinpong

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

sonarqubecloud[bot] avatar Apr 26 '23 19:04 sonarqubecloud[bot]

Hey @pinpong

Thanks for contribution 💚

Same as #201: This is a nice addition from a development point of view, however, need to do more testing to make sure this can't mess up with Payments flow state in some way 🤔

descorp avatar May 05 '23 20:05 descorp