adyen-magento2 icon indicating copy to clipboard operation
adyen-magento2 copied to clipboard

Composer.json doesnt contain "magento/module-quote-graph-ql": "*",

Open LexKoomen opened this issue 2 years ago • 3 comments

We had all graphQL modules in the composer replace because we did not use this feature yet. However the latest version (8.2.0) makes use of this module.

for example:

vendor/adyen/module-payment/Model/Cart/Payment/AdditionalDataProvider/AdyenCc.php use Magento\QuoteGraphQl\Model\Cart\Payment\AdditionalDataProviderInterface;

Maybe a best practice to add the module to the composer.json requirements?

LexKoomen avatar Apr 19 '22 09:04 LexKoomen

Hi @LexKoomen, I don't think we are talking about a bug here but it could be a great first contribution on Adyen module for Adobe Commerce!

jonathanribas avatar May 05 '22 11:05 jonathanribas

Hi @LexKoomen,

We also don't see anything breaking. Feel free to open a PR for this! I will mark this as an enhancement.

Cheers, Titus

tnaber avatar May 05 '22 11:05 tnaber

@LexKoomen if you are using replace in composer.json to remove all graphql modules, then adding it as a requirement in this module won't affect anything.

aligent-lturner avatar Jul 27 '22 03:07 aligent-lturner