adyen-ios icon indicating copy to clipboard operation
adyen-ios copied to clipboard

Adyen is defining public extensions on types they don't own

Open ffittschen opened this issue 3 years ago • 9 comments

Describe the challenge The Adyen SDK is defining a public extension on URL in URLHelpers.swift.

As these definitions are conflicting with extensions within our app, could you please move them behind the AdyenScope as you also do with extensions of other types that you don't own, instead of declaring it as a public extension on URL?

Additionally to URL, I also discovered public extensions on Result and View, which should probably be scoped as well.

ffittschen avatar Feb 21 '22 11:02 ffittschen

Hey @ffittschen

Thank you for the feedback! Indeed, we will move URL to AdyenScope.

public extensions on Result and View, which should probably be scoped as well.

Unfortunately, we cannot use AdyenScope with Result because it is generic and with View because it is a protocol.

descorp avatar Feb 21 '22 11:02 descorp

Hey @descorp any updates on this ? this is blocking us. Thanks

PrabhuShrinivas avatar Mar 23 '22 11:03 PrabhuShrinivas

Hey @PrabhuShrinivas

We have applied them on current develop branch and planing to release as v5.0.0. Fix for v4 is possible as well, however we didn't moved forward with this, because it will lead to a breaking change: we would have to deprecate this method first in v4.7.2, and finally remove in 4.7.3.

I am sorry to hear that this is a blocker for you. Is it possible to use other property name (at least for now)?

descorp avatar Mar 23 '22 17:03 descorp

@descorp any ETA for v5.0.0?

batschz avatar Apr 06 '22 09:04 batschz

Hey @batschz

We are planing v5.0.0 release in Q2(hopefully first half). Currently, we are working on a big release of Adyen Sessions for mobile

descorp avatar Apr 07 '22 07:04 descorp

@descorp since Q2 is almost about to end, are there any updates regarding this?

denizgueltek avatar Jun 15 '22 11:06 denizgueltek

Hey @denizgueltek

Are you asking for v4 or v5 ?

descorp avatar Jun 27 '22 15:06 descorp

Latest updated we had from you @descorp was that this blocker for us will be fixed on v5.0.0 right? So we are waiting for v5.0.0 if nothing has changed from your side?

Hey @PrabhuShrinivas

We have applied them on current develop branch and planing to release as v5.0.0. Fix for v4 is possible as well, however we didn't moved forward with this, because it will lead to a breaking change: we would have to deprecate this method first in v4.7.2, and finally remove in 4.7.3.

I am sorry to hear that this is a blocker for you. Is it possible to use other property name (at least for now)?

denizgueltek avatar Jun 27 '22 17:06 denizgueltek

Sorry for a loooong reply. We have going to remove it next major release for v4 PR is here

descorp avatar Sep 13 '22 09:09 descorp

since this has been fixed, will close this issue for now, please feel free to reopen or create a new issue if you're still experiencing issues!.

mohammedDehairy avatar Nov 10 '22 08:11 mohammedDehairy