adyen-ios
adyen-ios copied to clipboard
Only checking for .active on the `BrowserComponent`
Summary
- "Reverting" to only checking if the app is
.activeinstead of.active || .inactive
Noe of our tests are failing so I assume there are no tests covering this flow?
Is it possible to add them?
Do you have a suggestion on how to change the application state of UIApplication so this could be tested?
Noe of our tests are failing so I assume there are no tests covering this flow? Is it possible to add them?
Do you have a suggestion on how to change the application state of UIApplication so this could be tested?
The first approach that comes to my mind is:
- extracting
checkIfExternalAppDidOpeninto a separate entity that takesUIApplicationas dependency - hiding implementation details behind a new protocol like
ExtenalAppDetectingwithcheckIfExternalAppDidOpenmethod (or maybe a simple closure dependency would do?) - replacing direct
UIApplication.checkIfExternalAppDidOpencalls with the new dependency calls
Let me know if this works, we can think about other approaches
Quality Gate passed
Issues
0 New issues
0 Accepted issues
Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code