adyen-dotnet-api-library icon indicating copy to clipboard operation
adyen-dotnet-api-library copied to clipboard
verified publisher icon Adyen

Moved paywithgoogle to legacy and added googlepay type

Open jorismathijssen opened this issue 3 years ago • 1 comments

Description Moved the "paywithgoogle" type to a legacy object and changed the original GooglePayDetails object to work with "googlepay" type

Tested scenarios Not really tested, only added and ran the unit tests!

Fixes #657

jorismathijssen avatar Oct 19 '22 12:10 jorismathijssen

This is my first ever PR on Github and Adyen. I did not want to create a issue without a potential solution.

Feel free to completely ignore and close this PR if this is not the correct way.

Another potential (and maybe easier) solution might be to add an extra case to the PaymentMethodDetailsConverter.cs that just returns the existing GooglePayDetails.cs for the case googlepay.

This might give some problems when paywithgoogle and googlepay types are moving away from each other and fields are changed/added/removed. But for now, they are both identical.

jorismathijssen avatar Oct 19 '22 12:10 jorismathijssen

Hi @jorismathijssen,

Thanks a lot for reaching out to us and contributing. It seems all good, however if you could please rename the class GooglePayDetailsLegacy to PayWithGoogleDetails.

Best, Jilling Adyen

jillingk avatar Nov 04 '22 13:11 jillingk

Hi @jorismathijssen ,

Like @jillingk mentioned: Thanks for contributing. Our team is currently working on an automation overhaul of the library. Fixing this issue. We are therefore not merging this PR, but we will fix your problem soon in an upcoming release.

Kind Regards, Wouter Adyen

wboereboom avatar Nov 18 '22 07:11 wboereboom