adyen-dotnet-api-library
adyen-dotnet-api-library copied to clipboard
Adyen
Allow to use HttpClient instead of HttpWebRequest
Summary
HttpWebRequest produces performance issues.
Take a look at these articles for more information:
- https://josef.codes/you-are-probably-still-using-httpclient-wrong-and-it-is-destabilizing-your-software/
- https://makolyte.com/csharp-switch-from-using-httpwebrequest-to-httpclient/
- https://www.aspnetmonsters.com/2016/08/2016-08-27-httpclientwrong/
Proposed changes:
- Allow passing user's
HttpClientthat could be created through theHttpClientFactoryfor ASP.NET Core apps or manually for others - Rename
HttpUrlConnectionClienttoHttpWebRequestWrapperand use this implementation for backward compatibility
Fixed issue: #475
This pull request introduces 4 alerts and fixes 1 when merging 38207d48632c4594dd1718fcfdfefd5d50aa108a into 714f9d1ed0736760d882615be39b68b1563e0bd3 - view on LGTM.com
new alerts:
- 2 for Useless assignment to local variable
- 2 for Missing Dispose call on local IDisposable
fixed alerts:
- 1 for Missing Dispose call on local IDisposable
![lgtm-com[bot] avatar](https://avatars.githubusercontent.com/in/17324?v=4 "Published by a pub.dev verified publisher"){kind=small}
This pull request introduces 1 alert and fixes 1 when merging 6cadeeb93f405e97f6b99cb17177cc25f47013f3 into 714f9d1ed0736760d882615be39b68b1563e0bd3 - view on LGTM.com
new alerts:
- 1 for Missing Dispose call on local IDisposable
fixed alerts:
- 1 for Missing Dispose call on local IDisposable
@AlexandrosMor almost a month passed. Can anybody take a look at the PR, please? :)
@kipwoker We are currently busy as we maintain all the repos in the Adyen's github page. This pr needs extra attention as modifies core functionality. It is in our todo list :)
This pull request introduces 1 alert and fixes 1 when merging 569e7dc4a0c7d971ade105c2557e1eb049b66915 into d359dd759b11d77731ccd8a7b4e3a0c680547e99 - view on LGTM.com
new alerts:
- 1 for Missing Dispose call on local IDisposable
fixed alerts:
- 1 for Missing Dispose call on local IDisposable
This pull request introduces 1 alert and fixes 1 when merging d5357ccd3869cabaee97701ddbcc969114f8779c into d359dd759b11d77731ccd8a7b4e3a0c680547e99 - view on LGTM.com
new alerts:
- 1 for Missing Dispose call on local IDisposable
fixed alerts:
- 1 for Missing Dispose call on local IDisposable
This pull request introduces 1 alert and fixes 1 when merging cc79fb6014789819ec0aa1ab2d5d0a37e9590d89 into d359dd759b11d77731ccd8a7b4e3a0c680547e99 - view on LGTM.com
new alerts:
- 1 for Missing Dispose call on local IDisposable
fixed alerts:
- 1 for Missing Dispose call on local IDisposable
This pull request introduces 1 alert and fixes 1 when merging c420d55774ac4cf47da76e4a55295dc5414d7860 into f114b179e35c799c661064a762cb845c4ad57eff - view on LGTM.com
new alerts:
- 1 for Missing Dispose call on local IDisposable
fixed alerts:
- 1 for Missing Dispose call on local IDisposable
This seems like an important improvement. Is there anything we can do to help get it merged (testing etc.)?
@AlexandrosMor Would it be possible to pick this up again? We would really benefit from this change.
@Roeland54 Thank you for the message, the issue is that we are in the process to automate some parts of the library so we are putting some effort on that. Replacing the client and also support rest is in our plans but we are still busy. I hope in the coming month to be able to pick this one
We are currently working on the new http client in this pr #690 We would like to thank you for the help @kipwoker
kind regards, Alexandros Adyen