sabbath-school-lessons
sabbath-school-lessons copied to clipboard
Adventech
adding kin/2022-03
Pull Request check-list
- [x] Have you run
run.shornode deploy.js -b test -l [language] -q [quarter]? No, however, it follows the file structure suggested. - [x] Have you checked for semicolons in the titles?
NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.
For example, ./run.sh -l en -q 2022-01 or node deploy.js -b test -l en -q 2018-02.
Description of contribution
Reach out to me for any concerns.
Thanks, Frank!
We could consider changing the language code to the official kin to avoid conflict with Kikuyu, the language granted the ki code in ISO 639, in case someone contributes it to the project.
@alimness @VitalikL thoughts? :-)
Okay, I'm done changing it from ki to kin.
On Tue, Aug 30, 2022 at 2:42 AM Evan @.***> wrote:
Thanks, Frank! We could consider changing the language code to the official https://www.loc.gov/standards/iso639-2/php/langcodes_name.php?code_ID=236 kin to avoid conflict with Kikuyu, the language granted the ki code in ISO 639 https://en.wikipedia.org/wiki/ISO_639.
@alimness https://github.com/alimness @VitalikL https://github.com/VitalikL thoughts? :-)
— Reply to this email directly, view it on GitHub https://github.com/Adventech/sabbath-school-lessons/pull/1892#issuecomment-1231075816, or unsubscribe https://github.com/notifications/unsubscribe-auth/AXGASRV7Z3MBACNKMLYUXA3V3VYJRANCNFSM57NHSQ6A . You are receiving this because you authored the thread.Message ID: @.***>
Thanks @Burkifa23 ! As we are now official GC app, we need to confirm the source of the translation of the lesson. Is this an official translation of the lesson?
Thanks @Burkifa23 ! As we are now an official GC app, we need to confirm the source of the translation of the lesson. Is this an official translation of the lesson?
Yes, it is translated by the Rwandan SDA church which I scanned. I do understand your concerns sadly there is no digital version. I had tried checking from Sabbath school personal ministries archives but I did not find it there except on a Facebook group that posts the lessons daily called IBYIGISHO BY'ISHURI RYO KU ISABATO which may be the only way to vouch for kin/2022-03. If you want I can send you the scanned pdf file.
@Burkifa23 Great! Yes, if you can provide the PDF, just in case GC will have any questions / concerns. I will add the Bible translation and work on merging your PR. Thanks for contribution!
In case you don't receive the file or someone else wants the file, You can reach it from grosfi.ch/V9m7mLUgNAw. I was amazed by the bible passage reference parser so adding the bible verses would be very wonderful and if you need further help I will be available. Although, I don't know CoffeeScript I can help in other ways. Note to use the Bibiliya Yera (BYSB) as the bible version in order to get the 66 books as other versions either have more books or have outdated translations.
Thanks @Burkifa23 ! Just to confirm is this https://en.wikipedia.org/wiki/Kinyarwanda language? Because it seems like we can use rw language code for that.
Thanks @Burkifa23 ! Just to confirm is this https://en.wikipedia.org/wiki/Kinyarwanda language? Because it seems like we can use
rwlanguage code for that.
@VitalikL that is Kinyarwanda. We can use [rw] according to ISO 639-1 or [kin] according to ISO 639-2. Do you want me to change to [rw] or remain on [kin]?
@Burkifa23 I am not sure if you were creating files manually, but they are not currently in a format that would work for the app. Especially dates, have to be in a proper format. You can use create.js script to generate the structure for the quarterly.
Additionally, please remove package-lock.json from the commits
Hello VitalikL I want to add that I am not a church employee but just a member. My motivation to have this language posted is that it is spoken by almost a million Adventists worldwide and it pains me that it is not found on the application.
I want to understand the approval process before the language is posted on the app.
My father consulted the head of the translation department at the union level asking him if he could support us. But the answer was, the problem is known by the Union.
What is the likelihood that my contributions will be taken into consideration?
Do you have a time frame between the first submission and the posting on the app?
Sincerely, Frank.
On Thu, Sep 29, 2022 at 6:25 PM kwizera frank @.***> wrote:
Hello VitalikL, I did create the files manually because I didn't know how to use create.js. I realized that English dates are used even in other languages so I will apply the same changes to even the fourth quarter which am preparing.
On Thu, Sep 29, 2022 at 2:29 PM VitalikL @.***> wrote:
@Burkifa23 https://github.com/Burkifa23 I am not sure if you were creating files manually, but they are not currently in a format that would work for the app. Especially dates, have to be in a proper format. You can use create.js script to generate the structure for the quarterly.
Additionally, please remove package-lock.json from the commits
— Reply to this email directly, view it on GitHub https://github.com/Adventech/sabbath-school-lessons/pull/1892#issuecomment-1262367092, or unsubscribe https://github.com/notifications/unsubscribe-auth/AXGASRSWKCFPO6V22WVLFALWAWRT7ANCNFSM57NHSQ6A . You are receiving this because you were mentioned.Message ID: @.***>
Hello VitalikL, I did create the files manually because I didn't know how to use create.js. I realized that English dates are used even in other languages so I will apply the same changes to even the fourth quarter which am preparing.
On Thu, Sep 29, 2022 at 2:29 PM VitalikL @.***> wrote:
@Burkifa23 https://github.com/Burkifa23 I am not sure if you were creating files manually, but they are not currently in a format that would work for the app. Especially dates, have to be in a proper format. You can use create.js script to generate the structure for the quarterly.
Additionally, please remove package-lock.json from the commits
— Reply to this email directly, view it on GitHub https://github.com/Adventech/sabbath-school-lessons/pull/1892#issuecomment-1262367092, or unsubscribe https://github.com/notifications/unsubscribe-auth/AXGASRSWKCFPO6V22WVLFALWAWRT7ANCNFSM57NHSQ6A . You are receiving this because you were mentioned.Message ID: @.***>
Ooops! Looks like you have to fix some issues before I can merge this PR
| Error description | |
|---|---|
| 🛑 | Critical error. Can not parse the quarterly info: src/kin/2022-04/info.yml. Error: `YAMLException: bad indentation of a mapping entry (19:16)16 |
@VitalikL Hi ! Hope you are doing well. Where are the errors so that I can correct them, if possible? I would appreciate it very much if you helped me with it.
Hi @Burkifa23. I was able to work on it on my end (Quarter 4, 2022. plus added the Bible so the links would be clickable). Can you please sync your fork and create Pull Request for new lessons (days) that are empty for this quarter. I also made formatting adjustments to the content for kin/2022-04 - please follow that format. And for now, I will close this PR. Thank you for your contribution