Adrien Champion

Results 47 comments of Adrien Champion

I see that you do require the top-level hashconsed type to be a newtype. That's fine, but I think it's important it `Deref`s to the hashconsed value so that `Type`...

Also, `impls` really does two things at once: generate a static factory, and generate the constructors. I would split it in `factory` and `constructors`, with `factory = false, constructors =...

And since we need more than one crate to write the proc-macro, we should probably package the hashconsing crate itself in a `hashconsing` folder and have a top-level `Cargo.toml` dealing...

To be clear, I was talking about a flag to (de)activate the static factory. People who use the factory state-monad-style like #13 don't want a static factory. You would still...

Thank you for not giving up on this 😺 I can't see any examples, could you add some to facilitate the discussion?

Not going to lie it's pretty cool and convenient 😸

I wrote a few remarks, let me add the following so that we don't forget - [ ] support `struct`-like variant syntax, *i.e.* `MyVariant { field_1: Type, field_2: Type, ......