OneDarkPro icon indicating copy to clipboard operation
OneDarkPro copied to clipboard

"Match color" item background too light, makes some text hard to read.

Open stamminator opened this issue 4 years ago • 2 comments

image

When changing the "Match color" display item background to a darker color, it makes text much more readable without having too little contrast to quickly spot the matches.

image

If it's possible to use outlines instead of background colors for match colors like Visual Studio Code does, that would be ideal...

image

...but if not, a darker background color should suffice. I used RGB(81, 41, 163), which is just a darker shade of the existing Default color. Tested it on several different symbols in different languages and it looks pretty good. I'd suggest bringing such a change into the project.

stamminator avatar Mar 25 '21 17:03 stamminator

I've choosen RGB(54, 59, 69) so that the Match Text color matches the one inside of the outline box:

screenshot

I think that should be the way it's done in the standard themes as well.

flobernd avatar May 16 '22 08:05 flobernd

Yeah it's really hard to see the highlight especially the yellow one. image

icymaru avatar Nov 04 '22 07:11 icymaru