adding Kaios app and removing need to update chunks in build/index.html

Open shishirarora3 opened this issue 5 years ago • 4 comments

May 24 '20 05:05 shishirarora3

Can you elaborate a bit more on what this does?

Jun 15 '20 03:06 AdrianMachado

@AdrianMachado - Looks like the main purpose is this part: INLINE_RUNTIME_CHUNK=false in the build command. The reason you need this is because for Privileged apps, inline scripts are not allowed and the default is to inject the minified chunks inline.

I've fixed this a different way using the env-cmd library and making the build environment variables have INLINE_RUNTIME_CHUNK=false inside itself.

I'd recommend we do it that way vs. react scripts rewired and all of this other jazz. I've never had much luck using that package. More trouble than it's worth.

Jun 23 '20 17:06 patburke234

yes, main reason is to remove inline script. also, removed cursor and add manifest.webapp

Jun 24 '20 16:06 shishirarora3

@patburke234 so we shouldn't merge this in then if you already resolved it?

Jun 30 '20 18:06 AdrianMachado