openjdk-docker
openjdk-docker copied to clipboard
AdoptOpenJDK
Add 1909 and ltsc2019 configs to hotspot and openj9 official configs
Added 1909 and ltsc2019 configs to hotspot and openj9 official config files. As a not, nanoserver has not been added to openj9 configs because there were some issues last time I tried openj9 on nanoserver. I am hoping to enable tests for the openj9 team on nanoserver, but have yet to submit a PR for it.
Apologies! This change LGTM but I'd like to defer to @dinogun to make sure we're happy supporting these platforms going forward.
Would the project be open to building docker images and publishing them from GitHub actions? This would allow building and publishing more variants to at least the "unofficial" repos on docker hub. The windows support right now is quite a bit behind where the linux images are.
Would the project be open to building docker images and publishing them from GitHub actions? This would allow building and publishing more variants to at least the "unofficial" repos on docker hub. The windows support right now is quite a bit behind where the linux images are.
@slide apologies for the tardiness with this PR. Unfortunately we do not have a physical windows docker setup at Adopt and it is primarily because docker is extremely flaky on windows and we ran into a number of issues trying to keep it up and running. So now we have switched to doing the builds only at the official repo. However it is pretty difficult when we run into issues such as this - We had to turn off Windows nanoserver support and no easy way to even test fixes. @bharathappali is now working to have a local windows setup that can help us here.
In the meanwhile if you can help with the github actions based builds that is definitely very useful.
