xdpm icon indicating copy to clipboard operation
xdpm copied to clipboard

Support for Windows Subsystem for Linux

Open pklaschka opened this issue 5 years ago • 7 comments

While this may be more of an edge case, at least for me, it's useful to have support for the Windows Subsystem for Linux (providing me with a nicer shell to work with).

I've not tested if this breaks xdpm for other platforms, which is why for now I'll open this as a draft pull request, but if more people than just me are interested in this, I'd be willing to work on getting this "production-ready" to get merged here...

For now, it's just a bunch of crappy code, trying to get it to work (extracting the relevant paths in the subsystem is relatively difficult, so please excuse the "not-so-ideal" code)...

pklaschka avatar Jul 19 '19 13:07 pklaschka

@pklaschka looks like the commits for #35 ended up on this PR (I assume accidentally? 😄)

ashryanbeats avatar Dec 12 '19 19:12 ashryanbeats

@ashryanbeats And we now have a discussion in two places about this :laughing: See my response in #35 :wink:

pklaschka avatar Dec 12 '19 19:12 pklaschka

I've therefore reverted the merge in my master to not make this thing more complicated than it already is :slightly_smiling_face:

pklaschka avatar Dec 12 '19 19:12 pklaschka

@pklaschka @ashryanbeats Does it any reasons to support Linux based platforms if Adobe XD doesn't?

alexandrtovmach avatar Jun 09 '20 18:06 alexandrtovmach

Hi @alexandrtovmach,

I believe Pablo addressed this in the original PR:

it's useful to have support for the Windows Subsystem for Linux (providing me with a nicer shell to work with)

So it's not a question of Linux support, per se.

Is there further detail you'd need?

ashryanbeats avatar Jun 09 '20 19:06 ashryanbeats

@pklaschka @ashryanbeats Does it any reasons to support Linux based platforms if Adobe XD doesn't?

@alexandrtovmach There is the "Windows subsystem for Linux", which allows using a UNIX Shell in Windows (which makes development so much more enjoyable). Plus, development can be done on any platform. Personally, I develop on another machine (running Linux) and test on multiple machines (Windows, macOS). Therefore, while more of an edge-case, it does make sense to at least not "artificially prohibit" Linux-based platforms 😉. While I use my own, network-based xdpm-like solution for installing plugins on test machines during development (https://github.com/pklaschka/xd-deploy), I still use xdpm to build the plugins and do some development on my Windows laptop if I have to (e.g., when I'm traveling), meaning supporting WSL, for me, makes it much more enjoyable to use.

pklaschka avatar Jun 09 '20 19:06 pklaschka

@pklaschka Okay, now I see the case and it sounds reasonable 👍

@ashryanbeats Yeah, thanks for clarifying. I was confused with Linux and subsystem for Linux. Pablo comment makes it more clear for me. Thanks for quick answers.

BTW: Could you check my PRs? #39 #40

alexandrtovmach avatar Jun 09 '20 19:06 alexandrtovmach