acs-aem-commons icon indicating copy to clipboard operation
acs-aem-commons copied to clipboard

Issue/2899 remove xss taglib

Open SachinMali opened this issue 2 years ago • 1 comments

https://github.com/Adobe-Consulting-Services/acs-aem-commons/issues/2899 - Removed XSS Taglibs and updated JSPs that rely on it.

Verified there are no JSP Errors, see

  1. Version Compare Screen Shot 2022-10-09 at 7 35 30 PM

  2. Twitter and Named Image Transform Screen Shot 2022-10-09 at 7 35 38 PM

However, the Named Image transform component dialog needs to be revisited as the first tab title is NULL and image authoring via tav-2 is not yielding the desired result. I will create a separate issue to see if these need revamp..

SachinMali avatar Oct 09 '22 23:10 SachinMali

Codecov Report

Merging #2965 (b2d3d12) into acs-aem-commons-6.0.0 (788d84d) will decrease coverage by 0.01%. The diff coverage is n/a.

@@                     Coverage Diff                     @@
##             acs-aem-commons-6.0.0    #2965      +/-   ##
===========================================================
- Coverage                    54.67%   54.66%   -0.02%     
+ Complexity                    5256     5248       -8     
===========================================================
  Files                          694      693       -1     
  Lines                        28358    28350       -8     
  Branches                      3653     3653              
===========================================================
- Hits                         15506    15498       -8     
  Misses                       11399    11399              
  Partials                      1453     1453              

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov[bot] avatar Oct 09 '22 23:10 codecov[bot]