acs-aem-commons
acs-aem-commons copied to clipboard
issue #2960 shared-component-properties add support for lazy bindings, require AEM 6.5.7+
This is a proper approach to resolving https://github.com/Adobe-Consulting-Services/acs-aem-commons/issues/2960 in a way that requires an increase in the minimum supported AEM version to 6.5 SP7.
I rebased the master PR branch for pre-6.5.7 support and then added a commit to upgrade the platform dependencies to 6.5.7 and replace the use of reflection with proper LazyBinding types.
@joerghoh @kwin @HitmanInWis @davidjgonzalez
Codecov Report
Merging #2964 (c935883) into acs-aem-commons-6.0.0 (d8162c4) will increase coverage by
0.04%
. The diff coverage is92.42%
.
@@ Coverage Diff @@
## acs-aem-commons-6.0.0 #2964 +/- ##
===========================================================
+ Coverage 54.60% 54.64% +0.04%
- Complexity 5256 5274 +18
===========================================================
Files 697 697
Lines 28395 28418 +23
Branches 3658 3654 -4
===========================================================
+ Hits 15506 15530 +24
- Misses 11436 11438 +2
+ Partials 1453 1450 -3
Impacted Files | Coverage Δ | |
---|---|---|
...aredComponentPropertiesBindingsValuesProvider.java | 77.14% <88.63%> (+8.39%) |
:arrow_up: |
.../transformers/impl/AdjustImageTransformerImpl.java | 90.00% <100.00%> (ø) |
|
.../transformers/impl/ResizeImageTransformerImpl.java | 76.92% <100.00%> (ø) |
|
...s/transformers/impl/ScaleImageTransformerImpl.java | 100.00% <100.00%> (+13.33%) |
:arrow_up: |
...ties/shared/impl/SharedPropertiesRequestCache.java | 94.11% <100.00%> (+0.36%) |
:arrow_up: |
.../main/java/com/adobe/acs/commons/data/Variant.java | 66.66% <0.00%> (-0.97%) |
:arrow_down: |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
So... I think something related to these two links is causing some unit tests to break in java17 that pass in java11, AFTER upgrading to org.apache.sling.api
2.22.0:
SLING-8116 ValueMap - implement default methods using OSGI Converter
https://docs.oracle.com/en/java/javase/17/docs/api/java.base/java/lang/doc-files/ValueBased.html