acs-aem-commons icon indicating copy to clipboard operation
acs-aem-commons copied to clipboard

Acs aem commons 6.0.0

Open davidjgonzalez opened this issue 3 years ago • 4 comments

davidjgonzalez avatar Jul 22 '22 19:07 davidjgonzalez

Codecov Report

Merging #2916 (2fa72d9) into master (c3b31de) will increase coverage by 0.67%. The diff coverage is 0.00%.

@@             Coverage Diff              @@
##             master    #2916      +/-   ##
============================================
+ Coverage     54.51%   55.18%   +0.67%     
+ Complexity     5684     5389     -295     
============================================
  Files           758      710      -48     
  Lines         30982    28910    -2072     
  Branches       4005     3731     -274     
============================================
- Hits          16890    15955     -935     
+ Misses        12529    11460    -1069     
+ Partials       1563     1495      -68     
Impacted Files Coverage Δ
...mmons/adobeio/service/impl/AdobeioHealthcheck.java 0.00% <ø> (ø)
...ommons/adobeio/service/impl/AdobeioHelperImpl.java 0.00% <ø> (ø)
...mons/adobeio/service/impl/EndpointServiceImpl.java 70.37% <ø> (ø)
...s/adobeio/service/impl/IntegrationServiceImpl.java 42.30% <ø> (ø)
.../adobe/acs/commons/aep/impl/FpidCookieServlet.java 0.00% <0.00%> (ø)
...analysis/jcrchecksum/ChecksumGeneratorOptions.java 0.00% <ø> (ø)
...alysis/jcrchecksum/impl/ChecksumGeneratorImpl.java 87.59% <ø> (ø)
...mmons/analysis/jcrchecksum/impl/JSONGenerator.java 0.00% <ø> (ø)
...impl/options/AbstractChecksumGeneratorOptions.java 85.00% <ø> (ø)
.../impl/options/ChecksumGeneratorOptionsFactory.java 33.33% <ø> (ø)
... and 742 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov[bot] avatar Jul 22 '22 19:07 codecov[bot]

-13.000 lines to maintain. I'm impressed.

kwin avatar Jul 23 '22 09:07 kwin

...And more to go!

davidjgonzalez avatar Jul 23 '22 14:07 davidjgonzalez

@davidjgonzalez just a heads-up, the branch name of this PR is the same name as the tag that will be created when you run mvn clean release:perform for 6.0.0. It might cause an unusual error when you run that command unless you remember to delete the branch when you merge to master.

adamcin avatar Oct 09 '22 15:10 adamcin