acs-aem-commons icon indicating copy to clipboard operation
acs-aem-commons copied to clipboard

Issue #2876 - RobotsServlet Improvement

Open pahupe opened this issue 2 years ago • 1 comments

Two new OSGi config properties have been introduced:

  • allow.page.property.names and
  • disallow.page.property.names to generate ALLOW and DISALLOW rules for single pages (path/page.html)

These can be combined with existing properties

  • allow.property.names and
  • disallow.property.names to ALLOW single pages (path/page.html) while DISALLOWing nested paths (path/page/), or vice versa.

See unit tests com.adobe.acs.commons.wcm.impl.RobotsServletTest#testAllowPathDisallowPage and com.adobe.acs.commons.wcm.impl.RobotsServletTest#testDisallowPathAndAllowPage for use cases.

pahupe avatar Jul 22 '22 14:07 pahupe

Codecov Report

Merging #2882 (bd7ab04) into master (ce3787a) will increase coverage by 0.02%. The diff coverage is 100.00%.

:exclamation: Current head bd7ab04 differs from pull request most recent head 856823d. Consider uploading reports for the commit 856823d to get more accurate results

@@             Coverage Diff              @@
##             master    #2882      +/-   ##
============================================
+ Coverage     54.05%   54.07%   +0.02%     
- Complexity     5609     5615       +6     
============================================
  Files           756      756              
  Lines         30779    30795      +16     
  Branches       3978     3981       +3     
============================================
+ Hits          16637    16653      +16     
  Misses        12594    12594              
  Partials       1548     1548              
Impacted Files Coverage Δ
.../com/adobe/acs/commons/wcm/impl/RobotsServlet.java 94.08% <100.00%> (+0.61%) :arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov[bot] avatar Jul 22 '22 14:07 codecov[bot]