acs-aem-commons icon indicating copy to clipboard operation
acs-aem-commons copied to clipboard

AEM Environment Indicator rendered two times when opening a Experience Fragment variation

Open gquintillan opened this issue 2 years ago • 3 comments

Required Information

  • [X] AEM Version, including Service Packs, Cumulative Fix Packs, etc: AEM 6.5.12.0
  • [X] ACS AEM Commons Version: 5.0.14
  • [X] Reproducible on Latest? yes, tested also in 5.2.0

Expected Behavior

The AEM Environment indicador should be rendered only one time. image

Actual Behavior

The AEM Environment indicator is shown twice when there is an iframe, for instance in the Experience Fragments editor: image

Steps to Reproduce

  • Navigate to a Experience Fragment, for instance: http://localhost:4502/editor.html/content/experience-fragments/core-components-examples/library/simple-experience-fragment/master.html
  • Click in an existing variation
  • A new AEM Environment Indicator is rendered inside the iframe.

Links

The related code is here: https://github.com/Adobe-Consulting-Services/acs-aem-commons/blob/master/bundle/src/main/java/com/adobe/acs/commons/wcm/impl/AemEnvironmentIndicatorFilter.java#L229

gquintillan avatar Mar 29 '22 08:03 gquintillan

I will try to fix, and if I can't I would let you know.

gquintillan avatar Mar 29 '22 08:03 gquintillan

PR: https://github.com/Adobe-Consulting-Services/acs-aem-commons/pull/2807

gquintillan avatar Mar 29 '22 09:03 gquintillan

Fixed via https://github.com/Adobe-Consulting-Services/acs-aem-commons/pull/2807

davidjgonzalez avatar Apr 08 '22 21:04 davidjgonzalez

released in 5.3.0

davidjgonzalez avatar Sep 29 '22 13:09 davidjgonzalez