CodeClimate only accepts headers with Adobe as copyright owner

[kwin]

According to https://www.apache.org/licenses/LICENSE-2.0#apply the first line consists out of

Copyright [yyyy] [name of copyright owner]

The CodeClimate rule only accepts lines matching the following regex ?* Copyright (C) \d\d\d\d(( -)|( - \d\d\d\d))? Adobe That excludes all files having a different copyright owner than "Adobe".

That rule should be relaxed, as not for all source code files Adobe is necessarily the copyright owner (compare with https://softwareengineering.stackexchange.com/questions/150798/on-what-name-should-i-claim-copyright-in-open-source-software).

One such false positive is reported at https://codeclimate.com/github/Adobe-Consulting-Services/acs-aem-commons/pull/2499#issues.

[badvision]

I understand your concern. One counterpoint is disputed ownership can wreak havoc for the project as a whole. Case in point: Consider what happened to the Bukkit project a few years ago when one of the authors issued a takedown for all the code that they contributed. It basically killed the project. https://blog.jwf.io/2020/04/open-source-minecraft-bukkit-gpl/

Granted that was more to do with the GPL license than Apache but it is still a concern. Happy to hear others' perspectives on the topic, I don't really have a preference here unless it's the decision that helps ensure the long-term health of this community project.

[justinedelson]

The COPYRIGHT file at the root of the repository clearly states that "Adobe holds the copyright for all the files found in this repository."

[kwin]

The COPYRIGHT file is IMHO more targeted at consumers, not at contributors. If you have to give Adobe the full copyright, this should be clearly mentioned in https://github.com/Adobe-Consulting-Services/acs-aem-commons/blob/master/CONTRIBUTING.md. In contrast to e.g. https://github.com/adobe/aem-core-wcm-components/blob/master/CONTRIBUTING.md signing the Adobe CLA (which implies giving Adobe the copyright) is not necessary for this project... The main concern with giving Adobe the full copyright is that this would even allow Adobe to do anything with that source code (even selling it under a separate license which is incompatible with the ASF license)

[kwin]

Can some owners of this repo please clarify whether it is mandatory to grant the full copyright to Adobe for all new files? If that is the case then this should be clarified in the https://github.com/adobe/aem-core-wcm-components/blob/master/CONTRIBUTING.md. In that case most probably signing https://opensource.adobe.com/cla.html is necessary as well.

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[kwin]

@davidjgonzalez Can we please remove this enforced copyright donation. Recent changes made it clear that this whole project is not driven by Adobe as company but only engaged individuals. Forcing contributors to donate even the copyright to Adobe seems unfair to me (and pretty uncommon).