auto-cpufreq icon indicating copy to clipboard operation
auto-cpufreq copied to clipboard

[Feature] Tray-Icon for Status-Info

Open schinfo opened this issue 5 years ago • 19 comments

Can you add a tray icon (red / green) so that the status (active / inactive) of auto-cpufreq is visible.

schinfo avatar Aug 08 '20 17:08 schinfo

@AdnanHodzic I could help with this, maybe even implement. Had experience with python app indicator

Red-Eyed avatar Aug 08 '20 18:08 Red-Eyed

@AdnanHodzic could you please label issues by category and priority?

Red-Eyed avatar Aug 08 '20 18:08 Red-Eyed

Only you as the owner can set labels in GitHub ;-)

schinfo avatar Aug 08 '20 18:08 schinfo

@AdnanHodzic I could help with this, maybe even implement. Had experience with python app indicator

Sure, sounds like a nice idea.

Only you as the owner can set labels in GitHub ;-)

I just sent @Red-Eyed an invite to be a collaborator, with that status he'll be able to do these things :)

AdnanHodzic avatar Aug 09 '20 06:08 AdnanHodzic

If you do not want to reinvent the wheel there is this tool https://github.com/konkor/cpufreq

It does not do the automatic job of https://github.com/AdnanHodzic/auto-cpufreq, so both are working well together

It provides a nice icon with info Capture d’écran de 2020-08-14 09-29-12

Kwaadpepper avatar Aug 14 '20 07:08 Kwaadpepper

cpufreq maybe a very good tool, but the tray-icon doesn't work at Cinnamon

schinfo avatar Aug 14 '20 09:08 schinfo

@Kwaadpepper cpufreq conflicts with auto-cpufreq as they both install the same cpufreqctl binary.

Compare cpufreq's cpufreqctl and auto-cpufreq's cpufreqctl.sh.

yochananmarqos avatar Nov 30 '20 17:11 yochananmarqos

During install auto-cpufreq will take a backup of original cpufreqctl if it detects it and will use its own version which has slight improvements over the original. It will also restore the original cpufreqctl if auto-cpufreq is removed.

@Kwaadpepper cpufreq conflicts with auto-cpufreq as they both install the same cpufreqctl binary.

So this is not necessary true as auto-cpufreq will attempt to resolve any conflicts.

AdnanHodzic avatar Dec 06 '20 08:12 AdnanHodzic

@AdnanHodzic Ah, I see. That will have to be manually dealt with in the AUR package, see my install file. I've let the AUR maintainers know.

yochananmarqos avatar Dec 06 '20 15:12 yochananmarqos

@AdnanHodzic Ah, I see. That will have to be manually dealt with in the AUR package, see my install file. I've let the AUR maintainers know.

Cool thanks. I think it would be the best if AUR install file did the same thing auto-cpufreq is trying to do if cpufreqctl is detected, but let's see if @crian has something against this.

AdnanHodzic avatar Dec 06 '20 15:12 AdnanHodzic

@AdnanHodzic Ah, I see. That will have to be manually dealt with in the AUR package, see my install file. I've let the AUR maintainers know.

Cool thanks. I think it would be the best if AUR install file did the same thing auto-cpufreq is trying to do if cpufreqctl is detected, but let's see if @crian has something against this.

I'm fine with this. Currently updating the AUR pkg.

crian avatar Dec 06 '20 18:12 crian

@AdnanHodzic Ah, I see. That will have to be manually dealt with in the AUR package, see my install file. I've let the AUR maintainers know.

Cool thanks. I think it would be the best if AUR install file did the same thing auto-cpufreq is trying to do if cpufreqctl is detected, but let's see if @crian has something against this.

I'm fine with this. Currently updating the AUR pkg.

Nice, thanks. Let me know once this has been done, so I can close part of this discussion and I believe same thing is with #133.

AdnanHodzic avatar Dec 06 '20 18:12 AdnanHodzic

@AdnanHodzic Ah, I see. That will have to be manually dealt with in the AUR package, see my install file. I've let the AUR maintainers know.

Cool thanks. I think it would be the best if AUR install file did the same thing auto-cpufreq is trying to do if cpufreqctl is detected, but let's see if @crian has something against this.

I'm fine with this. Currently updating the AUR pkg.

Nice, thanks. Let me know once this has been done, so I can close part of this discussion and I believe same thing is with #133.

Done https://aur.archlinux.org/cgit/aur.git/commit/?h=auto-cpufreq-git&id=ff0101f0f6552eb085ede88f132d9cb1677f72f1

crian avatar Dec 06 '20 19:12 crian

@crian awesome, thanks!

@yochananmarqos and everybody else who had problems with cpufreqctl AUR conflict, if the problem persist please open a new issue as it got out of scope from the original request. Thanks

AdnanHodzic avatar Dec 06 '20 19:12 AdnanHodzic

@AdnanHodzic: Really? Thanks.

Thanks to our contributors for this release!

@crian

yochananmarqos avatar Dec 07 '20 00:12 yochananmarqos

@AdnanHodzic: Really? Thanks.

Thanks to our contributors for this release! @crian

I like to give people credit for their work. Even if it's as simple as creating new version of AUR package which fixes a bug or 2.

AdnanHodzic avatar Dec 07 '20 07:12 AdnanHodzic

@AdnanHodzic: Really? Thanks.

Thanks to our contributors for this release! @crian

I like to give people credit for their work. Even if it's as simple as creating new version of AUR package which fixes a bug or 2.

You should give the credit to @yochananmarqos as he fixed it.

crian avatar Dec 07 '20 07:12 crian

@crian thanks for the heads up, I completely missed it. @yochananmarqos sorry about that! Updated 1.5.1 release contributors list.

AdnanHodzic avatar Dec 07 '20 07:12 AdnanHodzic

After v1.7.0 release release and config/settings file going live. This feature is probably next highest item on my priority list. If anyone wants to give it a try at implementing this feature, I'll make sure to give you credit as part of releases page.

AdnanHodzic avatar Oct 16 '21 20:10 AdnanHodzic

Since I'm very limited with available time to do this myself, if you or anyone else wants to give it a try in implementing this functionality, please give it a try and contribute to the project and you will be credited for your work as part of future release.

AdnanHodzic avatar Nov 11 '22 05:11 AdnanHodzic

Any update on this , currently if i want to force switch to peformance mode , opening terminal > sudoing > writing password. A tray indicator will be nice to force switch on the fly ( 3 modes - auto, powersave, perforcmace ).

Can i use cpu-freq in meantime ? I am on Arch , installed auto-cpu freq thorugh install script. is there any better tray switching method available ?

KAGEYAM4 avatar Sep 09 '23 05:09 KAGEYAM4

If you install auto-cpufreq from changes that are on master branch right now, you'll get a desktop entry "auto-cpufreq" which allow you to easily switch between performance/powersave/default mode using auto-cpufreq GTK GUI app.

These changes will be released soon with upcoming v2.0 release and I'll make a video & update documentation about new functionality.

AdnanHodzic avatar Sep 09 '23 08:09 AdnanHodzic

If you install auto-cpufreq from changes that are on master branch right now, you'll get a desktop entry "auto-cpufreq" which allow you to easily switch between performance/powersave/default mode using auto-cpufreq GTK GUI app.

These changes will be released soon with upcoming v2.0 release and I'll make a video & update documentation about new functionality.

when switching mode using gtk gui , it prompts for password , is there a way to skip it ?

KAGEYAM4 avatar Sep 09 '23 09:09 KAGEYAM4

when switching mode using gtk gui , it prompts for password , is there a way to skip it ?

This was done by design. As that's when actual "sudo" privledges will be required in background.

@shadeyg56 now that I think of it, another idea could to require sudo password when auto-cpufreq GUI is initially started. Altough that's not intuative, since maybe some folks will just run it to see the stats.

AdnanHodzic avatar Sep 09 '23 09:09 AdnanHodzic

right, at some point the GUI HAS to prompt for root password.

Originally, the app actually did prompt during launch, but we changed it because of exactly what you said. I believe it is fine how it is now.

@KAGEYAM4 because overriding is a root action, it doesn't matter what medium you use, it will always need root somehow. It is quite quick to open up the GUI, select the override and enter your password. Please note that the GUI that is available in master has some known issues that are currently being worked on in another branch, but we hope to merge soon :)

shadeyg56 avatar Sep 09 '23 15:09 shadeyg56

I believe it is fine how it is now.

It's definitely fine as it is now.

AdnanHodzic avatar Sep 10 '23 11:09 AdnanHodzic

right, at some point the GUI HAS to prompt for root password.

Originally, the app actually did prompt during launch, but we changed it because of exactly what you said. I believe it is fine how it is now.

@KAGEYAM4 because overriding is a root action, it doesn't matter what medium you use, it will always need root somehow. It is quite quick to open up the GUI, select the override and enter your password. Please note that the GUI that is available in master has some known issues that are currently being worked on in another branch, but we hope to merge soon :)

Before this i used Windows and KDE, both had quick way to switch power governor, that's what i was hoping here. ( quick switch using tray option )

But seeing that this project whole purpose is to automate this process, i can see that this change won't be used by many.

KAGEYAM4 avatar Sep 10 '23 14:09 KAGEYAM4

Is there some other project which provides tray icon to switch power governor and dosen't confilit with auto-cpufreq ?

Or is there some permissions that i can change to add my user/group to not get prompted for sudo access ?

KAGEYAM4 avatar Sep 11 '23 15:09 KAGEYAM4

With release of v2.0.0 now auto-cpufreq has GUI. Hence, tray can be replicated in GNOME by adding auto-cpufreq to "dash" by right clicking and selecting "pin".

Closing the issue.

AdnanHodzic avatar Sep 30 '23 19:09 AdnanHodzic