Admiral-Piett
Admiral-Piett
Sounds great @kojisaikiAtSony - can you edit the description above? I added a list - and put my name against the first one. Want to follow that pattern?
@kojisaikiAtSony Boo GitHub 🙂. I guess because it's "my PR", I'll see if I can change that. I put you on there for now though. Thanks for hacking on SendMessage!
> Hi @Admiral-Piett , sorry it's too late, but I can start again. I may be able to get other team members to help us out, so can I get...
@macabu I don't understand what we're trying to accomplish here. What tags do you want that you don't currently get?
@macabu interesting - I honestly didn't know you could do that. Let's give it a whirl! Thanks!
@Thomasvdam Thanks for taking a look at this. Overall the goal of the change looks good to me, but we're in the middle of a large scale feature. I can't...
Current work in progress feature branch for this functionality and related discussion happening here - https://github.com/Admiral-Piett/goaws/pull/288.
@adventureisyou Your change for this looks good, but I think we also need to include a fix for this line. https://github.com/Admiral-Piett/goaws/pull/278/files#diff-e4a9df642f75a9a1287dc9408df6d0de9c9680711caa7d621db50bdd832e4daeR668. I think it needs to be `if !deleteEntry.Deleted` -...
@adventureisyou Quick follow up on this, any thoughts on my previous comment?
Hm, I think we're close here - looks like the tests are failing on `assert.Length` which I don't see as a function in the testify library? I think that's probably...