PokeFinder icon indicating copy to clipboard operation
PokeFinder copied to clipboard

[Gen 5] Wild beta branch missing delay of 1 for Special Grass Encounter

Open SexyMalasada opened this issue 1 year ago • 4 comments

Hello

I noticed today that in the Beta Gen5 Wild branch of PokéFinder, when searching for Special Grass encounters, it does not account for the delay of 1 that these encounters have vs normal grass encounters. As an example for comparison, I give the generator tab of PF and Generator of RNG Reporter for the same profile and seed. image image This isn't that urgent or important to fix ASAP, but just thought I'd mention! However the next issue definitely is!

Lmk if you need anything else, and hope you can address this!

SexyMalasada avatar Sep 02 '24 04:09 SexyMalasada

As a separate (but kinda related issue?) I wanted to test to see if this happened for the Surfing and Fishing options too, and to my surprise, it appears that clicking the 'Generate' button when using either Special Surfing or Special Fishing Encounter types in the Generator tab, will simply crash the program!

Lmk if you need anything else, and hope you can address these!

Separate the issues

Real96 avatar Sep 10 '24 16:09 Real96

As a separate (but kinda related issue?) I wanted to test to see if this happened for the Surfing and Fishing options too, and to my surprise, it appears that clicking the 'Generate' button when using either Special Surfing or Special Fishing Encounter types in the Generator tab, will simply crash the program! Lmk if you need anything else, and hope you can address these!

Separate the issues

Done!

SexyMalasada avatar Sep 14 '24 18:09 SexyMalasada

Related to this issue, doesn't simply putting 1 in the Delay box (which is now called Offset in latest commit) fix the problem?

Real96 avatar Oct 21 '24 16:10 Real96

Related to this issue, doesn't simply putting 1 in the Delay box (which is now called Offset in latest commit) fix the problem?

Hiya!

I guess it would, but it would probably be more 'clean' to have the program assume that 1 delay for these encounter by default - assuming it's something easy for you guys to implement ofc! If it's not, or until then, using the Offset box works yea!

SexyMalasada avatar Dec 01 '24 23:12 SexyMalasada