Aditya Sood

Results 86 comments of Aditya Sood

hi @easwars, yes I can work on that change too, please share the details with me

hi @zasweq do you mean we should delete this section of code in newInterceptor()? ``` if router.IsRouterFilter(filter.Filter) { // Ignore any filters after the router filter. The router itself //...

hi @zasweq so the `newInterceptor()` method in [serviceconfig.go](https://github.com/grpc/grpc-go/blob/2ee1fdd849505165744186e0cbe6ec07d6709514/xds/internal/resolver/serviceconfig.go#L294-L320) is the only location where the `router.IsRouterFilter()` check is currently being used the method iterates over the `ConfigSelector`'s filters, building a client...

hi @dfawley @zasweq @easwars so introducing the additional `rt.actionType == xdsresource.RouteActionRoute` check is causing some existing tests to fail, because they previously didn't expect to be errored-out for failing to...

thanks for the clarification @easwars * I'm working on fixing the tests failing because of the `rt.actionType != xdsresource.RouteActionRoute` check * also regarding the changes to `newInterceptor()`, it seems like...

hi @easwars and @zasweq TL;DR - I need help with understanding the design/logical flow of the codebase (especially the xds resolver and router relevant parts), where can I find the...

thanks a lot @easwars! I'll try to finish these over the weekend and get back

sorry for the delay in resolution, have been caught up with my day job I've been going through the shared docs, will try to close the PR over the weekend

hi @easwars and @zasweq apologies for the delay, I had written the test case last week but wasn't fully sure that my logic for causing the error was in tune...

hi @easwars, thanks for the review! I have included the above changes in the latest commit 1. I've changed the variable name to `errUnsupportedClientRouteAction` instead of the suggested `errUnsupportedRouteAction` -...