Aditya Sood

thanks @easwars, I'll get started on this

hi @easwars so I understand that we can additionally check for the terminal filter to also be a router filter as follows: ``` if !ret[i].Filter.IsTerminal() { return nil, fmt.Errorf("http filter...

Thank you, this is really helpful One quick query - do we need to create a `terminalNonRouterHTTPFilter` as well? (To cover the test case of a terminal filter failing the...

hi @easwars So initially I figured that there is a need for an additional `terminalHTTPFilter` because all the other filter types in the file (`httpFilter`, `errHTTPFilter`, `serverOnlyHTTPFilter`, `clientOnlyHTTPFilter`) were defined...

Raised #6281 for the Router filter check Also regarding the `errHTTPFilter`: > errHTTPFilter - Surprisingly not used anywhere in the codebase except in the init() of unmarshal_lds_test.go - might have...

@zasweq could you confirm if this is the cleanup you are referring to be done as part of this PR? https://github.com/grpc/grpc-go/pull/6248#issuecomment-1568873740

hi @zasweq @easwars I believe #6248 also fixes this issue, based on [these changes](https://github.com/grpc/grpc-go/pull/6248/files#diff-645ef5bd7a46bc17531453844144c0ce9418b3dd64d33a3f1930fbdf32a4de70L283-L287)? forgot to mention this ticket in that PR

I've submitted the CLA document

thanks for the review @easwars! I've locally implemented all the changes that have been suggested they are breaking a couple of tests in xds_resolver_test.go, so I'll work on resolving those...

hi @easwars and @tobotg it seems like there are testcases that use `RouteActionUnsupported` routes on xds, which are now failing because of this additional check on route type: ``` 1....