AdiBags icon indicating copy to clipboard operation
AdiBags copied to clipboard

Add currency display in Wrath Classic

Open Fiffers opened this issue 3 years ago • 3 comments

Addresses #707

Refactored a bit of the currency frame module to allow it to work with the currency API in Wrath Classic. With the old version, the GetCurrency local variables that were just making copies of the globals in Retail were overwriting those functions of the same name in Wrath Classic. Therefore, they needed to be renamed.

Otherwise, everything else is pretty straightforward. I wrote some functions to handle the differences between the two in an attempt to minimize the changes to the pre-existing codebase (159-181). Please have a look at these and let me know if you have a better solution in mind.

Lastly, I needed to take the GetCurrencyListInfo() from Wrath Classic and convert the resultant data to fit the mold of its retail counterpart. After all of this, it works great on Wrath Classic!

Sadly, I do not have a retail character, so I cannot test this PR on there. There should be no adverse effects, but it'd be helpful if someone could test these changes out and provide feedback on their results.

Here's a picture! =) image

Fiffers avatar Oct 09 '22 06:10 Fiffers

So i've tried this and it does show the currencies in the bag, which is great. My only problem is it shows all the currencies regardless of wether the "show on backpack" box is checked or not. Is there a way to do it or is the functionnality blocked somehow?

Thanks anyways ;)

Beldin31 avatar Oct 11 '22 17:10 Beldin31

Appreciate you truing to fix it but I have the same issue as the person above, it shows every currency no matter what, also live and classic use different versions of the addon so I don't think you need to worry about the live stuff you put in

Mentalscars avatar Oct 21 '22 19:10 Mentalscars

Addresses #707

Refactored a bit of the currency frame module to allow it to work with the currency API in Wrath Classic. With the old version, the GetCurrency local variables that were just making copies of the globals in Retail were overwriting those functions of the same name in Wrath Classic. Therefore, they needed to be renamed.

Otherwise, everything else is pretty straightforward. I wrote some functions to handle the differences between the two in an attempt to minimize the changes to the pre-existing codebase (159-181). Please have a look at these and let me know if you have a better solution in mind.

Lastly, I needed to take the GetCurrencyListInfo() from Wrath Classic and convert the resultant data to fit the mold of its retail counterpart. After all of this, it works great on Wrath Classic!

Sadly, I do not have a retail character, so I cannot test this PR on there. There should be no adverse effects, but it'd be helpful if someone could test these changes out and provide feedback on their results.

Here's a picture! =) image

Hey! I was wondering if you still play and are able to update this at all? It broke since the Ulduar 3.4.1 patch

PunkROC01 avatar Feb 27 '23 22:02 PunkROC01