AdiBags icon indicating copy to clipboard operation
AdiBags copied to clipboard

Currency display on Wrath

Open jelmerj opened this issue 2 years ago • 1 comments

Wrath Classic re-introduced the Currency tab, containing stuff like the pvp marks and badges/emblems. Would it be possible to reinstate the currency display on the bag for wrath?

Simply modifying CurrencyFrame.lua to make it load for Wrath doesnt do the trick unfortunately. It results in this error:

1x AdiBags\modules\CurrencyFrame.lua:131: attempt to call upvalue 'GetCurrencyListSize' (a nil value) [string "=[C]"]: ? [string "@Scrap\libs\CallbackHandler-1.0\CallbackHandler-1.0-7.lua"]:29: in function <...rap\libs\CallbackHandler-1.0\CallbackHandler-1.0.lua:25> [string "@Scrap\libs\CallbackHandler-1.0\CallbackHandler-1.0-7.lua"]:64: in function SendMessage' [string "@AdiBags\core\Bags.lua"]:131: in function GetFrame' [string "@AdiBags\core\Bags.lua"]:83: in function Open' [string "@AdiBags\core\Bags.lua"]:119: in function <AdiBags\core\Bags.lua:115> [string "=(tail call)"]: ? [string "=(tail call)"]: ? [string "TOGGLEBACKPACK"]:1: in function <[string "TOGGLEBACKPACK"]:1>`

jelmerj avatar Sep 22 '22 07:09 jelmerj

+1 from me, this feature would be quite nice to have.

rtroberts avatar Oct 06 '22 21:10 rtroberts

I was the person who posts #929 but this was a new issue for me. Because I had a working currency display on AdiBags for like a month and a half, until 3.4.1 dropped. Then it disappeared

PunkROC01 avatar Feb 08 '23 22:02 PunkROC01

I was the person who posts #929 but this was a new issue for me. Because I had a working currency display on AdiBags for like a month and a half, until 3.4.1 dropped. Then it disappeared

I don't know what to tell you, but you're mistaken. Other than superficial changes with the new theme engine implementation (#880), the CurrencyFrame module hasn't seen any updates since issue #707 was opened. Currently, AdiBags only supports currencies on retail, not classic/WotLK.

https://github.com/AdiAddons/AdiBags/blob/c09e86e76c01e938ed6e2f0e898f6200a2697d14/modules/CurrencyFrame.lua#L25-L28

Talyrius avatar Feb 09 '23 01:02 Talyrius