tsurlfilter icon indicating copy to clipboard operation
tsurlfilter copied to clipboard

Do not convert $redirect-rule to $redirect (or do it only in the specific cases)

Open AdamWr opened this issue 6 months ago • 0 comments

Related to - https://github.com/AdguardTeam/AdguardFilters/issues/184832 Incorrect blocking is caused by this rule:

*$image,redirect-rule=1x1-transparent.gif,domain=seznamzpravy.cz|sport.cz|seznam.cz|sbazar.cz|firmy.cz|super.cz|garaz.cz|stream.cz|novinky.cz

from EasyList Czech and Slovak filter list. It redirects all images instead of only these which are blocked.

The problem is that currently $redirect-rule is converted to $redirect, but it's not the same and it might causes breakage. So maybe it should not be converted to $redirect at all, or should be converted only if there is specific path/url in the rule?

Related - https://github.com/w3c/webextensions/issues/493

AdamWr avatar Jul 29 '24 09:07 AdamWr