dnsproxy icon indicating copy to clipboard operation
dnsproxy copied to clipboard

Published 20 hours ago • verified publisher icon AdguardTeam

feat(docker): build docker images with buildkit, add actions

Open initdc opened this issue 2 years ago • 5 comments

Hello, I add an muti-arch docker workflow.

initdc avatar Apr 08 '22 15:04 initdc

@ameshkov ping. It would be great to have this in, which would solve #208. Since a new version has been published, just an image pull would have allowed upgrading.

pataquets avatar Jun 06 '22 17:06 pataquets

@ameshkov Aside from what you've pointed out, there are a lot of fundamental issues in this PR compared to the AGH CI process. Most notably, the hard coding of the tag to latest, with no support for individual releases.

agneevX avatar Jul 21 '22 13:07 agneevX

@ameshkov Aside from what you've pointed out, there are a lot of fundamental issues in this PR compared to the AGH CI process. Most notably, the hard coding of the tag to latest, with no support for individual releases.

Do you mean this? https://github.com/initdc/cloudflared/blob/feat/docker/Dockerfile#L13

initdc avatar Jul 21 '22 15:07 initdc

@agneevX well, we should start with something, right?

But yeah, adding a version tag would be useful (i.e. pushing both :latest and :vX.X.X).

ameshkov avatar Jul 21 '22 16:07 ameshkov

Check the latest workflow. https://github.com/initdc/golang-project-workflow

initdc avatar Jul 23 '22 10:07 initdc

Watch out for DNS issues with Alpine: https://christoph.luppri.ch/fixing-dns-resolution-for-ruby-on-alpine-linux I can't say for sure if it will affect dnsproxy, so dropping here for consideration by the experts.

pataquets avatar Oct 12 '22 10:10 pataquets

Yes, dnsproxy is affected.

URL schemes without FQDNs do not resolve.

agneevX avatar Oct 12 '22 10:10 agneevX

I've update my golang project workflow with version supported, https://github.com/initdc/golang-project-workflow/blob/master/docker-tag.rb Will you consider having a try ?

initdc avatar Oct 12 '22 17:10 initdc

Why was this PR closed? I am interested in using dnsproxy in Kubernetes with cert-manager, but I cannot find official container images. Is there a plan to maintain official images? Thanks!

maelvls avatar Jun 09 '23 15:06 maelvls

@ameshkov Check out what I did previously elsewhere and if this "Dockerfile only" PR would feel like a good enough starting point for dnsproxy maintainers. Automating builds using Github Actions might come later, which would enable a public, built from source, official image. No commitment, as of now, but knowing maintainers' stance on this would be great.

pataquets avatar Jun 13 '23 15:06 pataquets

@pataquets no worries, in the end we made it ourselves in a way similar to how AdGuard Home images are published.

https://hub.docker.com/r/adguard/dnsproxy

ameshkov avatar Jul 25 '23 14:07 ameshkov