SafariConverterLib icon indicating copy to clipboard operation
SafariConverterLib copied to clipboard

AdGuard for Safari cannot apply some rules, that existing in filters

Open adguard-bot opened this issue 10 months ago • 33 comments

For example, ###termly-code-snippet-support in AdGaurd Cookie filter - cookie notification is not hidden. When I add the rule to user rules, it is applied. After removing the rule from user filter I can't reproduce an issue.

Issue URL (Annoyance)

https://news.itsfoss.com/macos-meets-linux/

Comment

Cookie banner at bottom. Username: @MineGene

Screenshots

Screenshot 1

Screenshot 1

System configuration

Information Value
AdGuard product: AdGuard for Safari v1.11.22
Filters: Ad blocking:
AdGuard Base

Privacy:
AdGuard Tracking Protection

Social widgets:
AdGuard Social Media

Annoyances:
AdGuard Cookie Notices,
AdGuard Popups,
AdGuard Mobile App Banners,
AdGuard Other Annoyances,
AdGuard Widgets

Security:
Online Malicious URL Blocklist,
Phishing URL Blocklist,
Scam Blocklist by DurableNapkin,
uBlock Origin – Badware risks

adguard-bot avatar Jun 12 '25 05:06 adguard-bot

Also has a membership advert down the bottom.

Image

MineGene avatar Jun 12 '25 05:06 MineGene

Same problem https://github.com/AdguardTeam/AdguardFilters/issues/206816#issuecomment-2974463405

Alex-302 avatar Jun 18 '25 07:06 Alex-302

https://github.com/AdguardTeam/AdguardFilters/issues/207785 ||intergient.com^ or ||cdn.intergient.com^ is not applied.

Alex-302 avatar Jun 20 '25 09:06 Alex-302

Same issue here I guess (previously opened https://github.com/AdguardTeam/AdGuardForSafari/issues/1079). I’ll add a few details I observed, although not sure if some of them might be specific to me:

It seems to be mostly cookie banners and other parts of the annoyances filter for me. About 80 % of popular websites I visit show cookie banners, most of them have valid filter rules that are not applied. Just on a few countable websites, they’re still blocked.

The bug is present on macOS, latest versions, even after purging all directories that belong to AdGuard for Safari, and I think it also is on iOS (although more difficult to verify here).

jarne avatar Jun 21 '25 19:06 jarne

Another case https://github.com/AdguardTeam/AdguardFilters/issues/208060

anpanman.jp,poisknews.ru,petslike.ua,rossetimr.ru,halvacard.ru,rewards.msi.com,polonez.com.tr,tskb.com.tr,tacirler.com.tr,dobrograd.ru,turkiyesigorta.com.tr,woodupp.pl,puzat.ru,san-tatsu.jp,ddos-guard.ru,4fund.com,loverepublic.ru,park-mobile.ru,sms-activate.guru,polaris.ru,tel-special.com,lastepoch.com,tsmileclub.com,nipponsteel.com,novaposhtaglobal.ua,scania.com,tera.cz,yunusonline.com,tuitam.com.pl,cccmh.co.jp,resecurity.com,nspk.ru,eirc.spb.ru,petslike.ua,tocalo.co.jp,carlcare.com,actions.5ka.ru,weareplaystation.fr,shop.fruitbedrijfheijnen.nl,roistat.com,spb-neo.ru,hs-sonpo.co.jp,pomosch.app,petroneonline.com,npc.by,comotto.docomo.ne.jp,kuki.pl,finbo.pl,gutscheine.n-tv.de,talos.com,svitroslyn.ua,abb.com,global.abb,weddingpark.net,honor.com,centr-hirurgii-spb.ru,choiceqr.com,cumhuriyet.com.tr,pracowniapozarzadowa.pl,myfin.by,buildtoconnect.com,lebensmittelverband.de,muztorg.ru,iwate-u.ac.jp,bus.sovavto.ru,trustedrevie.ws,garantibbva.com.tr,omu.ac.jp,rgs.ru,moskvich-auto.ru,shatura.com,thunderobot.su,software.charliemonroe.net,sms-activate.org,sukcespopoznansku.pl,stokrotka.pl,granline.net,cadelta.ru,bonprix.ee,bonprix.lv,app.firstbase.io,bcci.tv,iplt20.com,bathroommountain.co.uk,hyundai-autopole.ru,portalpacjenta.luxmed.pl,onlinesim.io,apteka911.ua,bill.nevalink.net,yasamhastaneleri.com,rvbar.ru,ginverter.com,hmi-basen.dk,zuhalmuzik.com,aeternathegame.com,profile.ru,silverstonetek.com,vitkovicetours.pl,m-1gp.com,arisdiamond.com,fs.com,novyny.live,sixt.com.tr,abdullahkigili.com,onlinesim.ru,kawasaki.it,mts.by,mpr-shop.ru,parafgenc.com.tr,megamallbucuresti.ro,mangaplaza.com,filescan.io,obligacjeskarbowe.pl,pc.domains,ask.fm,girlstyle.com,oggusto.com,tatuzinho.com.br,ringoo.ua,paraf.com.tr,pagefly.io,pdfreaderpro.com,35mm.online,edu-sense.com,yamibuy.com,nbb-netzgesellschaft.de,darkflash.com,rostec.ru,megatop.by,almi-dostavka.by,objective-see.org,mytu.co,gingerweb.jp,teenmegaworld.net,amersport.ru,r-stahl.com,pilsnerurquell.com,thatskygame.com,opendata.mkrf.ru,pos.gosuslugi.ru,anybus.com,worldskillspoland.org.pl,unternehmensbericht.boehringer-ingelheim.de,bolshoibelarus.by,h2.live,shop.huawei.ru,xn--80ahmohdapg.xn--80asehdb,don24.ru,ddos-guard.net,telegramic.org,klick.ee,urbanlifehk.com,asko-home.ru,agroportal.ua,hihonor.com,virtualexpodubai.com,meduniwien.ac.at,boosteroid.com,monosnap.com,translate.com,elamed.com,occrp.org,revitonica.ru,edukatico.org,bankbsu.ch,rbi.ru,gazetasp.com.br,sbtnews.com.br,ambassador-manufaktura.ru,findeks.com,sddhelp.ru,antoninilab.it,spiegel.de,lra-aoe.de,unicreditgroup.eu,koreanair.com,euroairport.com,ninateka.pl,humboldt-foundation.de,7mind.de,ufsp-coronavirus.ch,foph-coronavirus.ch,ofsp-coronavirus.ch,bag-coronavirus.ch,fertstertdialog.com,3djake.de,zettains.ru,iport.ru,prowin.net,slewo.com,ages.at,adlershof.de,heckenpflanzen-heijnen.de,pinarprotein.com,intexty.com,galatawindenerji.com,coubassistant.com,pro-palliativ.ru,drega.de,fischer.group,fischertechnik.de,fischer.de,mclaren.com,key-test.ru,uhren4you.de,cat.com,stammzellen-verstehen.de,saga.hamburg,kroati.de,ilvi.com,wome.com.tr,ytddownloader.com,tw-calc.net,tmasgff.de,kinnarps.de,teyit.org,otuzbeslik.com,mydramalist.com,lostmechanics.com,ecco-verde.com,kktcell.com,vodafone.ua,dsm.com,tdlorien.ru,smart-gadget.ru,elawin.com,dalmatinskiportal.hr,samocat.net,bayragidevral.com,the-village.ru,roxroyal.com,model-kartei.de,sinpas.com.tr,takeda.com,sepas.com.tr,gamertech.hu,bevachip.hu,gamecitycorner.hu,gamecity.hu,nudo.com.tr,erisun.com.tr,erislergida.com.tr,miluni.com.tr,gelbe-liste.de,magdeburger.com.tr,zrzutka.pl,kioskla.co,pyur.com,why-tech.it,ilike.pet,hhv.de,maxcamping.de,mariin.ru,hiya.com,wall-art.de,wifire.tv,hyundai.ru,bb.lv,scotchwhisky.com,reisebank.de,rtl.de,computacenter.com,reyden-x.com,persil.de,modhoster.de,bug.hr,kigili.com,buddhism.ru,natwest.com,crowdfinder.be,snob.ru,stib-mivb.be,englishhome.com,commuterclub.co.uk,colliers.com,novmak.com,gugik.gov.pl,eibach.de,oreopeople.com,eishockeynews.de,nature.com,1mobil.hu,tvpaprika.ro,tvpaprika.hu,minimaxtv.rs,minimaxcz.tv,minimaxro.tv,minimaxtv.si,minimax.hu,docmorris.de,leroymerlin.pl,malavida.com,prodir.com,joautok.hu,redditinc.com,oogfonds.nl,soft32.com,buffalo.de,donaukurier.de,le1hebdo.fr,turbo-c.soft32.com,juridischloket.nl,statusbrew.com,zumnorde.de,rbs.co.uk,okayfreedom.com,statarea.com,werkenbijbdo.nl##body .cookie

When added this rule - cookie banner is hidded. When removed - still hidden.

Alex-302 avatar Jun 23 '25 09:06 Alex-302

https://github.com/AdguardTeam/AdguardFilters/issues/207999 the same problem. ||contributions.guardianapis.com^ is in Other Annoyances filter, but not applied in Safari on Mac. Works after adding to user rules, and still works after removing.

Alex-302 avatar Jul 01 '25 07:07 Alex-302

One more https://github.com/AdguardTeam/AdguardFilters/issues/208585

||consent.trustarc.com^$third-party

Alex-302 avatar Jul 01 '25 08:07 Alex-302

https://github.com/AdguardTeam/AdguardFilters/issues/208252

Alex-302 avatar Jul 01 '25 14:07 Alex-302

same https://github.com/AdguardTeam/AdguardFilters/issues/208621

Alex-302 avatar Jul 02 '25 14:07 Alex-302

One more: https://github.com/AdguardTeam/AdguardFilters/issues/209005

piquark6046 avatar Jul 08 '25 23:07 piquark6046

Recently got impacted by this after having to intentionally turn off all blocking. Upon turning AdGuard back on, seemingly half the rules (for annoyances, etc) didn't get applied.

I managed to work around it by disabling all annoyances lists and then only enabling the Fanboy one, and that seemed to work. I re-enabled the AdGuard annoyances list but not sure if it took effect.

So my theory is that some rules must be crashing the conversion process and thus the probability of success depends on the order in which you enable the lists. Seems that the Fanboy list does not have anything that breaks the converter (or only breaks it at the very end), where as the AdGuard one breaks the converter early on, before any rules are actually converted, meaning no blocking is actually occurring.

Rjevski avatar Jul 12 '25 23:07 Rjevski

AdGuard for iOS is getting the upgrade to the new SafariConverterLib V3 this week, it should solve quite a few issues here.

ameshkov avatar Jul 15 '25 13:07 ameshkov

@ameshkov what about macOS? I have this issue (well I think it's this issue) primarily on macOS.

Rjevski avatar Jul 15 '25 18:07 Rjevski

@Rjevski on macOS it will take a bit more time, there's a major update that's being tested internally and the migration is already done there. However, this version is not yet available to general public and it is planned to enter beta test in August.

ameshkov avatar Jul 15 '25 18:07 ameshkov

Perfect, thanks for the info.

Sent from my iPhone

On 15 Jul 2025, at 20:09, Andrey Meshkov @.***> wrote:

 [https://avatars.githubusercontent.com/u/5947035?s=20&v=4]ameshkov left a comment (AdguardTeam/SafariConverterLib#81)https://github.com/AdguardTeam/SafariConverterLib/issues/81#issuecomment-3074793810

@Rjevskihttps://github.com/Rjevski on macOS it will take a bit more time, there's a major update that's being tested internally and the migration is already done there. However, this version is not yet available to general public and it is planned to enter beta test in August.

— Reply to this email directly, view it on GitHubhttps://github.com/AdguardTeam/SafariConverterLib/issues/81#issuecomment-3074793810, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AK4C6PQQBJ43AH5ETLN74RL3IU7WTAVCNFSM6AAAAAB7PXTKPGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTANZUG44TGOBRGA. You are receiving this because you were mentioned.Message ID: @.***>

Rjevski avatar Jul 15 '25 18:07 Rjevski

Same: https://github.com/AdguardTeam/AdguardFilters/issues/209430

gamespark.jp,s.cinemacafe.net##.box-sns

The above filter exists in https://filters.adtidy.org/ios/filters/4_optimized.txt. However, it is not applied.

piquark6046 avatar Jul 15 '25 22:07 piquark6046

Same: https://github.com/AdguardTeam/AdguardFilters/issues/209429

jp##.box-sns

The above filter exists in https://filters.adtidy.org/ios/filters/4_optimized.txt. However, it is not applied.

piquark6046 avatar Jul 15 '25 23:07 piquark6046

@piquark6046 but this rule is not supposed to work on the website from the issue? https://github.com/AdguardTeam/SafariConverterLib/issues/81#issuecomment-3075988236

This rule works okay: netsecurity.ne.jp##.box-sns

Regarding https://github.com/AdguardTeam/SafariConverterLib/issues/81#issuecomment-3075998183, this is a legit bug: https://github.com/AdguardTeam/SafariConverterLib/issues/99

ameshkov avatar Jul 16 '25 09:07 ameshkov

@Alex-302 I cannot reproduce the original issue, there's no Cookie banner.

With this one what rule is supposed to hide the cookie banner on Reddit? ##reddit-cookie-banner seems to be working. https://github.com/AdguardTeam/SafariConverterLib/issues/81#issuecomment-2983016046

ameshkov avatar Jul 16 '25 09:07 ameshkov

@ameshkov 1 - the CMP was changed. 2 - the rule exists in Cookie filter, but not applied (Frankfurt IP). Works in user rules:

preview.redd.it,reddit.com,reddittorjg6rue252oqsxryoxengawnmo46qy4kyii5wtqnwfj4ooad.onion##shreddit-async-loader[bundlename="reddit_cookie_banner"]

With 1032 not reproduced.

Alex-302 avatar Jul 16 '25 12:07 Alex-302

So far it seems that most if not all of the reported issues here are not reproduced in the new AG for iOS build.

If there's anything else, please report it, otherwise I would prefer to close this issue.

ameshkov avatar Jul 17 '25 14:07 ameshkov

Same: https://github.com/AdguardTeam/AdguardFilters/issues/209576

Screenshot

Image

piquark6046 avatar Jul 18 '25 01:07 piquark6046

@piquark6046 is it reproduced with the latest AG for iOS?

ameshkov avatar Jul 18 '25 07:07 ameshkov

https://github.com/AdguardTeam/SafariConverterLib/issues/81#issuecomment-3087970916 If you mean the 36kr.jp case, yes

piquark6046 avatar Jul 18 '25 07:07 piquark6046

Same: https://github.com/AdguardTeam/AdguardFilters/issues/209828

eegg.fun##iframe[id^="rlad_"][src^="/ad_html/"]

The above filter exists in https://filters.adtidy.org/ios/filters/11_optimized.txt. However, it is not applied.

piquark6046 avatar Jul 22 '25 03:07 piquark6046

@piquark6046 This rule does not match that element

Details Image

Yuki's rule eegg.fun##iframe[id][src^="/ad_html/"] matches, will check after the next filters update. You also check.

Alex-302 avatar Jul 22 '25 15:07 Alex-302

https://github.com/AdguardTeam/SafariConverterLib/issues/81#issuecomment-3103290281

Oh... My bad. I am confused.

piquark6046 avatar Jul 22 '25 15:07 piquark6046

@piquark6046 So what, did you check?

On my end all good.

Alex-302 avatar Jul 23 '25 08:07 Alex-302

https://github.com/AdguardTeam/SafariConverterLib/issues/81#issuecomment-3106583855 I did not check the updated filter. Will Check.

piquark6046 avatar Jul 23 '25 09:07 piquark6046

I did not check the updated filter. Will Check.

@piquark6046 so what?

Alex-302 avatar Jul 31 '25 11:07 Alex-302