SafariConverterLib
SafariConverterLib copied to clipboard
Improve `$genericblock` implementation
trafficstars
In the current implementation $genericblock is basically the same as $document, i.e. it disables filtering completely.
This implementation can be improved if we change the way the list is ordered.
Here's how the rules should be ordered:
- Generic
css-display-nonerules $generichideignore-previous-rules- Generic url blocking rules
$genericblockignore-previous-rules- Domain-specific
css-display-none rules $elemhideignore-previous-rules- Domain-specific url blocking rules
$urlblockignore-previous-rules
In addition to that $genericblock rules' resource-types should be limited and exclude document. In this case it will not cover cosmetic rules.
Actually, when we add ignore-following-rules support, it will be easier to solve it.