HostlistCompiler icon indicating copy to clipboard operation
HostlistCompiler copied to clipboard

`.js` should not be processed as TLD

Open Alex-302 opened this issue 2 years ago • 1 comments

Sample rules from AdGuard DNS filter:

.3.n.2.1.l50.js
||113.17.188.*.js
.n.2.1.js^

Original issue: https://github.com/AdguardTeam/AdGuardSDNSFilter/issues/1224 https://github.com/AdguardTeam/AdGuardSDNSFilter/issues/1243

Alex-302 avatar Feb 20 '23 14:02 Alex-302

In theory, the same would apply to .png, .jpg, .jpeg, .webp, .gif, .mp4, .swf, .mp3, .avi, .ogg, .flac, .mkv, and .json, but personally I'd be wary of disqualifying such entries unless they end with ^ or |, or if it's a pure domain entry that starts with a letter or number.

Of the ones above, I know I've come across at least .gif, .jpg, and swf from time to time when converting lists into DNS lists.

DandelionSprout avatar Feb 07 '24 07:02 DandelionSprout