FiltersCompiler icon indicating copy to clipboard operation
FiltersCompiler copied to clipboard

Transform rules for Samsung Browser compatibility

Open ameshkov opened this issue 8 years ago • 0 comments

@ameshkov commented on Mon Aug 21 2017

The problem is that Samsung cannot handle ^ symbol when it means the end of URL:

For instance: ||google-analytics.com/analytics.js^ won't match https://google-analytics.com/analytics.js

To fix this issue we should add a duplicate rule with | instead of ^ for every rule matching this regexp: ^(@@)?\|\|.+?/.+?\^(\$.*)?$

For instance, this rule:

`||google-analytics.com/analytics.js^$third-party`

Should be replaced with two:

`||google-analytics.com/analytics.js^$third-party`
`||google-analytics.com/analytics.js|$third-party`

It should be done for Content Blocker filters only


@Mizzick commented on Wed Oct 18 2017

It should be done for Content Blocker filters only

But what is Content FIlter? How to define it?


@ameshkov commented on Sun Oct 22 2017

But what is Content FIlter? How to define it?

I mean rules for iOS, Safari, and for Android Content Blocker

ameshkov avatar Feb 14 '18 17:02 ameshkov