AdguardForiOS icon indicating copy to clipboard operation
AdguardForiOS copied to clipboard

Handle the case with too many DNS rules gracefully

Open Zsombe opened this issue 2 years ago • 3 comments

In AdGuard iOS when the sum of all DNS rules exceeds approximately 535000 rules. WiFI crashes when this number of rules is exceeded.

Zsombe avatar Sep 25 '23 13:09 Zsombe

DnsLibs notifies AdGuard that the engine exceeds the maximum allowed memory limit and it then forcibly stops the tunnel, this may look like a Wi-Fi crash because the tunnel is then restarted due to an "on demand" rule.

The solution would be to start the tunnel anyway with a limited engine instance and notify the user about that via a normal OS notification. The error code that should be used is AGDPE_MEM_LIMIT_REACHED.

ameshkov avatar Sep 26 '23 09:09 ameshkov

I have this issue on cellar, as well. It just breaks the data functionality of my phone completely. Will 4.6 fix this as well?

Greigh avatar Oct 16 '23 23:10 Greigh

It will work, but it does not mean that it's a good idea to use a blocklist that's heavier than the limit as all rules above the limit will be discarded.

ameshkov avatar Oct 17 '23 07:10 ameshkov