AdguardForWindows icon indicating copy to clipboard operation
AdguardForWindows copied to clipboard
verified publisher icon AdguardTeam

Allow selection of multiple filters (for bulk actions) in Filter editor

Open contribucious opened this issue 2 years ago • 3 comments

Issue Details

Hello! :wave:

  Basically, in the (DNS) Filter Editor, I would like to be able to select multiple filters at once, for bulk actions. Just like with rules.

Why? Especially for list maintainers and frequent private/public rule makers, it would be very useful when doing various tests (to let only User rules enabled quickly, etc.).

Thanks in advance! :thumbsup:

 

Proposed solution

:a: Basic implementation

Allow to use CTRL and SHIFT keys (combined with mouse — or up/down arrow keys for the latter) to define the selection. And Space bar to toggle the enabled/disabled state on the set.

:bulb: Advantages
  • Not too complicated to implement I would say and
  • consistent with the fact that already feasible on the rules.  

:b: More advanced implementation (complementary to the first one)

A global checkbox above/below the filters for selection. Once ticked, a selection checkbox appears on each filter, possibly on the left.

:thought_balloon: View implementation idea …  

In case the left position is chosen, I would say … migrate permanently the state ones to the right, in the form of toggle switches, as used in the AdGuard Browser extension, and make them gray/untouchable during a selection, only left for information about the current status to the user during his selection.

 

:a: or :b: Common things …

Reveal …
:eye_speech_bubble: In both cases, with an slight adaptation to pluralize in the bottom gear icon menu Enable filter and Disable filter when multiple filters are selected.
:eyes: In both cases, once multiple filters are selected, ideally show the AdGuard mascot on the right panel — and possibly duplicate there the bottom available actions on them in the form of green buttons: Enable (or Enable selection), Disable (or Disable selection) and maybe also Delete (or Delete selection). Think about mail clients.

 

Alternative solution

Basic implementation only added for now for this v7.

More advanced implementation added later in the v8 — to take advantage of both the renewal of the user interface and the new features¹ scheduled for addition at this place to add a global checkbox at the top or bottom of the list of filters.

¹ See this issue and that one — which is handled in the first one.

contribucious avatar Mar 16 '23 21:03 contribucious

For the team (issue handling)

Reveal …

 

Note n°:one:

Regarding the more advanced implementation described above, although I didn't find anything with a search, I'm pretty sure that @gork7777 (or another person) had already proposed this in the past with even a modified screenshot as far as I remember, but probably just in a simple post and not in a dedicated issue apparently.

:arrow_right: Else, just mark my issue as duplicated.

 

Note n°:two:

I guess this issue is a candidate for the https://github.com/AdguardTeam/AdguardForWindows/labels/filter%20editor label too.
:arrow_right_hook: As are at least all my other related ones available here (open ones) and there (closed ones). :wink:

contribucious avatar Mar 16 '23 22:03 contribucious

@contribucious Hi there!

Definitely a useful improvement, we'll do it. Thanks a lot.

Aydinv13 avatar Mar 28 '23 08:03 Aydinv13

@Aydinv13 Great! Thank you very much!

P.S. Don't forget my Note n°2 from my second post, just above yours. :relaxed:
(Except for not using this freshly created label anymore. Or if it's handled in a second time, of course.)

contribucious avatar Mar 28 '23 16:03 contribucious