AdguardForWindows icon indicating copy to clipboard operation
AdguardForWindows copied to clipboard

`(DNS) Filter Editor` — Set the focus to `User rules` by default (for use of the up/down arrow keys)

Open contribucious opened this issue 2 years ago • 0 comments

(:wave:) Steps to reproduce

  1. Right-click on the AdGuard systray icon > Tools > (DNS) Filter editor.
  2. Press the down arrow key.

Expected behavior

Instead of User rules, the filter located just below it becomes selected.

Actual behavior

Nothing happens.

Analysis :mag:

Although User rules seems to be visually selected (as you can see below), the down arrow key will only work after a mouse click on it first. To set the focus on it.

AdGuard_hcLNknxKca  

Let's go further: case with some user rules present

Click me to read more …

  AdGuard_qyWA7zHrZM

Now, let's open the (DNS) Filter Editor window when some user rules are present (see screenshot above).

Two problems found
  1. The user does not know first of all whether pressing the down arrow key will select the next entry in the "left part" list or in the "right part" list.

  2. He will find that in fact, nothing happens by pressing the down arrow key.

Recommended resolution (in case you choose to prioritize the left part, the most logical IMHO)

  1. Visually highlight the selected entry in the left part more strongly than the one in the right part (however, please always keep a good contrast between background and text, for a good readability). And put an adequate focus on it for use of the up/down directional keys.

  2. Allow the user to use the left/right directional keys to switch from one part to the other. (The up/down arrow keys will then use the selected part and the entry with the focus in that part will now visually stand out more than the one in the opposite part.)

 


Thank you in advance. :thumbsup:

[:computer: Environment]  AdGuard 7.10.1 (latest stable) on Windows 10 Pro 21H2 (OS Build 19044.1826)

contribucious avatar Jul 13 '22 17:07 contribucious