AdguardForMac icon indicating copy to clipboard operation
AdguardForMac copied to clipboard

AdGuard userscript scheme doesn't work with GitHub

Open LemmaEOF opened this issue 3 years ago • 0 comments

Currently, AdGuard prepends any link ending in .user.js with a URL scheme to open the page in AdGuard. This can cause issues with non-raw GitHub code view pages, as the pages for userscripts end in .user.js but are not userscripts in and of themselves.

Steps to reproduce

  1. Visit a GitHub repo containing a userscript, such as refined-twitter-lite.
  2. Click on the index.user.js link to view the file on GitHub.
  3. AdGuard intercept issue occurs

Expected behavior

AdGuard should allow the user to visit the page, as it is not a raw JS file.

Actual behavior

In this situation, since the link in the example repo would be https://github.com/giuseppeg/refined-twitter-lite/blob/master/index.user.js, AdGuard would attempt to open the page even though it is not the raw text of a userscript. The resulting HTML file will not be parseable as a userscript, and accessing the raw file to add to AdGuard is much more difficult, since the only way to get to it is by clicking the "Raw" button on the GitHub page.

Screenshot:

Capto_Capture 2022-03-18_06-19-15_PM

Customer ID

Diagnostic report attached to ticket ID 587088

Your environment

  • Environment name and version: (e.g. Chrome 59): Safari Version 15.3 (17612.4.9.1.8)
  • Any specific potentially conflicting software installed: (e.g. antiviruses, firewalls, traffic counters, cleaners) None other than AdGuard

LemmaEOF avatar Mar 19 '22 01:03 LemmaEOF