AdguardForAndroid icon indicating copy to clipboard operation
AdguardForAndroid copied to clipboard

Add custom DNS server option broken

Open Glassertje opened this issue 1 year ago • 11 comments

Please answer the following questions for yourself before submitting an issue.

  • [X] I am running the latest version
  • [X] I checked the documentation and found no answer
  • [X] I checked to make sure that this issue has not already been filed

AdGuard version

4.3.1

Environment

- OS: Android 14
- Device: Samsung S23+ One UI 6.0

Root access

  • [ ] No.

What filters do you have enabled?

AdGuard Base filter, AdGuard Mobile Ads filter, AdGuard Dutch filter, AdGuard Tracking Protection filter, AdGuard Social Media filter, AdGuard Cookie Notices filter, AdGuard Popups filter, AdGuard Mobile App Banners filter, AdGuard Widgets filter, AdGuard Other Annoyances filter

What Stealth Mode options do you have enabled?

No response

Issue Details

Steps to reproduce:

  1. I click add DNS server
  2. I copy/paste my 2 domains. I tried DoH, DoT and DoQ
  3. i get a red message that server isn't responding or not exist

Expected Behavior

That the added servers are working. As it was in app version 4.2 and before.

Actual Behavior

If i add these in the custom DNS field i get a red message that server isn't responding or not exist.

Screenshots

Screenshot 1:

<vb>

Additional Information

I have 2 AGH installs with 2 domain names. If i add these in the custom DNS field i get a red message that server isn't responding or not exist. In Android version 4.2 and before, it works flawless. I just tested in app version 4.2 and DNS is working. So something is broke. I also tested the latest nightly but also not working.

Sometimes i can add my 2 servers, but then after a while i don't have any internet.

I can provide you the 2 domains, but not public.

I also send a support ticket 864038, i have send 2 debug logs to the ticket email. 1 from version 4.2 and the other is 4.3.1. I want to ask if you gonna reveal any kind of log, to hide the 2 domains. Be course I don't want them public known.

Glassertje avatar Jan 22 '24 21:01 Glassertje

@Glassertje Hi! Try adding these servers separately. Will both servers be added successfully?

Versty avatar Jan 24 '24 10:01 Versty

I tried everything. It only works if I go back to version 4.2. Did not try version 4.3

24 jan 2024 11:02:05 Diana @.***>:

@Glassertje[https://github.com/Glassertje] Hi! Try adding these servers separately. Will both servers be added successfully?

— Reply to this email directly, view it on GitHub[https://github.com/AdguardTeam/AdguardForAndroid/issues/5183#issuecomment-1907798364], or unsubscribe[https://github.com/notifications/unsubscribe-auth/A3MJDB3E6AM5WGDCJA7GGA3YQDLZ3AVCNFSM6AAAAABCF3TYY2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMBXG44TQMZWGQ]. You are receiving this because you were mentioned. [Tracking afbeelding][https://github.com/notifications/beacon/A3MJDB4FUP55YVTJ6KFY3N3YQDLZ3A5CNFSM6AAAAABCF3TYY2WGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTTRW2YVY.gif]

Glassertje avatar Jan 24 '24 11:01 Glassertje

I tried that again. If 1 add 1 custom DNS i can add it. If i want to add the second than i can't add it and get the red message.

Edit: Just deleted the custom DNS and added it again, and now again it won't work. Getting again the red message that server don't respond or exist. After that deleted the custom DNS again and try it again, and i can add it and works. so, something is going wrong. Whit version 4.2 no problems add all.

Edit; I setup Adguard with 1 AdGuard Home DNS to test if my internet still disconnect. Past days I used the private dns of my S23+ and also working flawless.

Edit2; My internet is not disconnecting, but can't add a second server.

Glassertje avatar Jan 24 '24 11:01 Glassertje

@Glassertje Thank you for details. We would like to reproduce this issue on our side. Please provide both problematic dns servers to our mail [email protected], mention the 5183 issue number in the subject.

Versty avatar Jan 25 '24 08:01 Versty

@Versty Email send. Thank you for the help.

Glassertje avatar Jan 25 '24 08:01 Glassertje

@Glassertje We have received the email from you and are currently investigating this issue.

Versty avatar Jan 25 '24 08:01 Versty

@Versty a little update. Sins my last message i tested 1 custom DNS in version 4.3.1. Yesterday again i had no internet. Took about a minute before my internet was back, when i opent a app. For now i went back to 4.2.0.

Glassertje avatar Jan 27 '24 13:01 Glassertje

@Glassertje Thanks to you we have found the root cause. This issue will be fixed in the next updates. You can track the status of the fix in https://github.com/AdguardTeam/DnsLibs/issues/217

Versty avatar Feb 01 '24 11:02 Versty

@Glassertje Thanks to you we have found the root cause. This issue will be fixed in the next updates. You can track the status of the fix in AdguardTeam/DnsLibs#217

Thank you for letting me know and glad that it will be fixed.

Glassertje avatar Feb 01 '24 11:02 Glassertje

The fix is available in the latest Android nightly, and will be included into upcoming 4.4 beta.

sfionov avatar Mar 18 '24 12:03 sfionov

Thank you for letting me know and for the good work you guys do.

Glassertje avatar Mar 18 '24 22:03 Glassertje