AdguardForAndroid
AdguardForAndroid copied to clipboard
Gray out duplicate filterlists
Conceptually & visually similar to https://github.com/AdguardTeam/AdguardForAndroid/issues/633#issuecomment-232982708 (& derivative issues #697 #698 #699), duplicating or wholly overlapping/inclusive filterlists selections in Settings > Ad Blocker
should be grayed out. Much of this has to do with addition of AG & Easylist variants of essentially the same list. As a bonus, it should decrease some filterlist updating server load.
This means:
Blank | Both | Choose A |
---|---|---|
☐ A + B | ☑️ A + B | ⬜ A + B |
↳☐ A | ↳⬜ A | ↳☑️ A |
↳☐ B | ↳⬜ B | ↳⬜ B |
Add'l idea: If 1 then chooses B from Choose A state, it should go back to Both state.
The 1s I see are:
- [ ] 'French Filter' → 'Liste FR'
- [ ] 'List-KR' → ('Korean Adblock List' & 'Youslist')
- In this & similar cases, maybe consider automatically having AG :ballot_box_with_check: 'List-KR' if user chooses both 'Korean Adblock List' & 'Youslist', also.
- [ ] 'Adguard Annoyances Filter' →{All its broken out subfilters}
Or at the very least de-duplication of existing entries in other lists, so maybe something like this happens locally:
- AG downloads all lists subscribed to (in the event of an update)
- Compares all lists with each other
- Removes duplicate entries and compresses the lists
Eventually there will be duplication issues especially if you use large data sets so this could be one way to handle this? You could set this to happen only when the device is plugged in and charging incase there is a noticeable battery drain ?
@versavius I believe filter deduplication already happens internally, or filters are done such it's irrelevant. (I think I read that someplace in these issues.)
Cool thanks, Adguard App on Android is just awesome, no need to root :)