AdguardFilters icon indicating copy to clipboard operation
AdguardFilters copied to clipboard

Update YouTube rules for tracking URL parameters

Open Tiagoquix opened this issue 1 year ago • 10 comments

Prerequisites

  • [x] This is not an ad/bug report;
  • [x] My code follows the guidelines and syntax of this project;
  • [x] I have performed a self-review of my own changes;
  • [x] My changes do not break web sites, apps and files structure.

What problem does the pull request fix?

If the problem does not fall under any category that is listed here, please write a comment below in corresponding section

  • [ ] Missed ads or ad leftovers;
  • [ ] Website or app doesn't work properly;
  • [ ] AdGuard gets detected on a website;
  • [x] Missed analytics or tracker;
  • [ ] Social media buttons — share, like, tweet, etc;
  • [ ] Annoyances — pop-ups, cookie warnings, etc;
  • [ ] Filters maintenance.

What issue is being fixed?

Enter the issue address

Example: https://www.youtube.com/watch?v=T4rQcT_SOV8&embeds_widget_referrer=leagueclient&embeds_referring_euri=https://127.0.0.1/index.html&source_ve_path=XXXXXXX&feature=emb_title

Add your comment and screenshots

  1. Your comment

This pull requests adds more filters for the YouTube site. Specifically, the goal is to remove tracking parameters from URLs. I've also extended the current filters to include the other YouTube sites.

embeds_widget_referrer is an extension to the current one (embeds_referring_euri). feature and si are used when sharing YouTube links to track which person sent it. They're also used for other tracking purposes (such as the one in the example URL of this pull request).

I don't know if source_ve_path could be considered as tracking. But, given that it is not necessary for the video to play in the user's browser, it might be worth adding too.

  1. Screenshots

Not needed.

Terms

  • [x] By submitting this issue, I agree that pull request does not contain private info and all conditions are met

Tiagoquix avatar Feb 28 '24 22:02 Tiagoquix

Removing si broke SuperChat and thus disabled.

Yuki2718 avatar Mar 01 '24 12:03 Yuki2718

Hello there. I have removed si and added bp and source_ve_path.

bp is used on the YouTube logo button according to which event they're promoting on the moment. Right now, when you click on the logo button to go to the home page, it goes to https://www.youtube.com/?bp=wgUCEAE%3D.

source_ve_path does not seem necessary for the video to play. I have got this parameter from the client of the game League of Legends.

I have also adjust the website order after ,domain=.

Tiagoquix avatar Mar 01 '24 15:03 Tiagoquix

Hi. What the source of links with these parameters? Please provide examples for the listed domains.

Alex-302 avatar Mar 07 '24 14:03 Alex-302

Hello. I provided examples in my original post.

I just extended the parameters to other links since they are from the same company and, therefore, other links may also be affected.

Tiagoquix avatar Mar 07 '24 21:03 Tiagoquix

No example of removeparam=pp. We certainly do not want to repeat the breakage by si. Also note we only remove tracking parameter and not all parameter.

Yuki2718 avatar Mar 08 '24 09:03 Yuki2718

pp is already removed: https://github.com/AdguardTeam/AdguardFilters/blob/master/TrackParamFilter/sections/specific.txt#L287

For me, all of what I included can by considered as tracking parameters since they aren't needed for the video to function in the user's browser.

Tiagoquix avatar Mar 09 '24 00:03 Tiagoquix

We do not remove parameter just because doing so does not break the site. embeds_widget_referrer and embeds_referring_euri look to be trackparam, but I'm not sure about source_ve_path and bp.

Yuki2718 avatar Mar 09 '24 04:03 Yuki2718

bp, in my opinion, is a tracking parameter because it only exists when clicking on the website logo, and this is not essential for the website to function.

About source_ve_path, I found this topic on the internet that contains another example with the same parameter, and it is not necessary to play the video (if you access the link just using watch?v=VIDEOID the video still plays normally). My example was from the client of the game League of Legends, and your browser also does not need this parameter to play the video (if you click in the video to play externally in your browser).

To clarify, let's remember that ad-blockers extensions (such as the AdGuard one) only works in non-embedded browsers (it would not work in Chromium Embedded Framework, for example), and in browsers the YouTube web site functionality remains normal even with the removal of the parameter (from my own experience).

Tiagoquix avatar Mar 09 '24 12:03 Tiagoquix

How we can reproduce URL with that parameters?

Alex-302 avatar Mar 11 '24 13:03 Alex-302

Here's how:

bp: clicking on the YouTube logo at the top-left corner. This is not always available, as it seems to be specific to YouTube "events". As of 11 March 2024, there's no event going on, so this parameter is not available to test.

embeds_referring_euri, embeds_widget_referrer and source_ve_path: it seems to be related to the Chromium Embedded Framework (CEF). You can only reproduce this by copying YouTube video links inside application or game clients. For my example, I got it from the League of Legends game client.

feature: YouTube mobile, when sharing videos. Typically the parameter is ?feature=shared.

pp: copying video links from YouTube search results page (any search arguments). Right-click on any video and copy its link from the search results page.

Tiagoquix avatar Mar 11 '24 15:03 Tiagoquix

I can see the embeds_referring_euri, embeds_referring_origin (not included on this PR), feature and source_ve_path parameters here:

https://www.portugues.com.br/gramatica/adjetivo-adverbio-tracos-que-os-distinguem.html

Scroll down to youtube embed and click on it, click on the share icon, then click on "..." or on the link.

https://www.youtube.com/watch?embeds_referring_euri=https%3A%2F%2Fwww.portugues.com.br%2F&source_ve_path=Mjg2NjQsMTY0NTA2&feature=emb_share&v=ZXSrLCTkqOs

In the last embed I see embeds_referring_origin

https://www.youtube.com/watch?embeds_referring_euri=https%3A%2F%2Fwww.portugues.com.br%2F&embeds_referring_origin=null&source_ve_path=Mjg2NjQsMTY0NTAz&feature=emb_share&v=2Od3I7-DofA

D4niloMR avatar Mar 19 '24 02:03 D4niloMR

Olá, Danilo! :brazil:

Thank you for letting us know about embeds_referring_origin. I have added it to this PR too.

Tiagoquix avatar Mar 19 '24 02:03 Tiagoquix