AdguardFilters
AdguardFilters copied to clipboard
AdguardTeam
Getting rid of JS rules, used to set a cookie
Prerequisites
- [X] I checked the documentation and found no answer;
- [X] I checked to make sure that this issue has not already been filed;
- [X] This is not an ad/bug report.
Problem description
Prerequisites
- [X] I checked the documentation and found no answer;
- [X] I checked to make sure that this issue has not already been filed;
- [X] This is not an ad/bug report.
Problem description
We have ~317 JS rules, used to set a cookie. They can be found by:
document.cookie =
They must be replaced by set-cookie / set-cookie-reload / trusted-set-cookie-reload scriptlet rules.
There are many old rules, so first you need to check if the site is available, and then the need for the rule.
- For convenience, you can work in a separate browser
- Retrieve the list of domains, clean up duplicates and check if sites exist (if redirects occur, we assume that the site is dead).
- All such rules can be merged into one file, convert them to exception rules and import as custom filter. Then go down the list and check if the rules are needed (other types of problems not related to these rules are skipped).
- If the site is dead - add domains in the comment below. Then we will remove them from the filters.
In order not to overlap with other filter maintainers, it is desirable to perform batch rule replacement via pull-requests (5-10 rules per PR).
Important
It should be checked with a Dutch or German VPN, because otherwise the cookie usage messages may not appear.
Dead domain: first-comment.com https://github.com/AdguardTeam/AdguardFilters/issues/83355
@Alex-302 How to address if a rule mentions an issue in the closed AdGuard Forum?
@piquark6046 If it's not clear from the rule what it's for, and the site is still working - just convert to a scriptlet.
Dead domain: exrapidleech.info https://github.com/jspenguin2017/uBlockProtector/issues/167 https://github.com/AdguardTeam/AdguardFilters/issues/4957
Dead domain: yts.life https://github.com/AdguardTeam/AdguardFilters/issues/43664
Dead website: pfm.pl https://github.com/AdguardTeam/AdguardFilters/issues/26890
Dead website: sinemavitrini.com https://github.com/AdguardTeam/AdguardFilters/issues/34548
An inaccessible website: fantasti.cc https://github.com/AdguardTeam/AdguardFilters/issues/6540
An inaccessible website: mofosex.com https://github.com/AdguardTeam/AdguardFilters/issues/6128
How to address if a rule mentions an issue in the closed AdGuard Forum?
maybe was copied to public archive.org?
https://github.com/AdguardTeam/AdguardFilters/issues/166756#issuecomment-2063770466 I considered it as an inaccessible domain because It took long time to connect. However, I can confirm that the deleted rules are outdated.
Inaccessible domain: thewirecutter.com
If you try to visit, you will be redirected to nytimes.com.