AdguardBrowserExtension icon indicating copy to clipboard operation
AdguardBrowserExtension copied to clipboard

$all should have priority over rule with $popup

Open 105th opened this issue 11 months ago • 0 comments

AdGuard Extension version

4.3.29 beta

Browser version

Chrome 122

OS version

macOS 12.5

What filters do you have enabled?

No response

What Stealth Mode options do you have enabled?

No response

Issue Details

In the current schema, a rule with $all has lower priority than a rule with $popup. This causes an issue in the tswebextension part, as seen here: https://github.com/AdguardTeam/tsurlfilter/blob/tswebextension-v1.0.16/packages/tswebextension/src/lib/mv2/background/request/request-blocking-api.ts#L115. When a rule with $popup is selected and the tab with the opened ad is not new—such as after clicking on a banner—we can neither cancel the request nor show our dummy blocking page, nor can we close the tab.

Therefore, in cases where an ad opens in the current tab, it leads to incorrect logic by allowing these requests to bypass the intended blocking mechanism.

Expected Behavior

When opening ad in current tab - it should be blocked as well.

Screenshots

Screenshot 1:

Additional Information

No response

105th avatar Mar 04 '24 10:03 105th