AdguardBrowserExtension icon indicating copy to clipboard operation
AdguardBrowserExtension copied to clipboard

In some case `$replace` rule breaks video player

Open AdamWr opened this issue 3 years ago • 3 comments

Issue Details

  • AdGuard version:
    • 4.0.161
  • Browser and version:
    • Firefox 99

Steps to reproduce

  1. Add this rule:
/playback/v3/videoPlaybackInfo$replace=/("vendorAttributes" : {)[\s\S]*?}\,[\s\S]*?("streaming")/\$1}}\,\n\$2/,domain=go.discovery.com|discoveryplus.com|go.tlc.com|watch.hgtv.com|investigationdiscovery.com|sciencechannel.com
  1. Go to - https://go.discovery.com/video/alaska-the-last-frontier-discovery/a-whole-new-frontier US IP needed.

Expected Behavior

Video player should works fine.

Actual Behavior

Video player is broken. It seems that it's due to \n in $replace rule.

Screenshots

Screenshot:

image

AdamWr avatar Apr 06 '22 14:04 AdamWr

@AdamWr I wasn't able to reproduce it.

Birbber avatar Apr 20 '22 12:04 Birbber

I still can reproduce it, if I add mentioned rule to user rules.

Screenshot

image

If rule is not added (or if \n is removed from the rule), then video works fine.

Screenshot

image

AdamWr avatar Apr 20 '22 12:04 AdamWr

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] avatar Jun 19 '22 13:06 github-actions[bot]