AdguardBrowserExtension icon indicating copy to clipboard operation
AdguardBrowserExtension copied to clipboard

Assistant iframe styles are affected by cosmetic rules specific for websites

Open Alex-302 opened this issue 4 years ago • 1 comments

@adguard-bot commented on Mon Aug 30 2021

Issue URL (Incorrect Blocking)

https://www.tv2.no/a/6805835/

Comment

When trying to block an element with Nordic Filters turned on, the buttons at the bottom of the AdGuard popup are missing ("Select a different element", "Preview", "Block"). When Nordic Filters (under "Language-specific") are turned off, the buttons appear. Possible conflict between Nordic Filters and element blocking?

Screenshots

Screenshot 1

Screenshot 1

Screenshot 2

Screenshot 2

System configuration

Information value
AdGuard product: AdGuard Browser extension v3.6.6
Browser: Chrome
Stealth mode: disabled
Filters: Ad Blocking:
AdGuard Base

Language-specific:
Dandelion Sprout's Nordic Filters
Other extensions used: nothing relevant

@DandelionSprout commented on Mon Aug 30 2021

I seem to have found the problem: AdGuard's element picker is using html and body elements for seemingly no valid reason, which causes www.tv2.no#$#body:not(.broom, .lab) { padding-top: 70px !important } to take effect for it.

This seems like a pretty severe bug in AdGuard Browser Extension, and it's a 50:50 chance if I can even make a good temporary fix for it.


@DandelionSprout commented on Mon Aug 30 2021

I've now added a tempfix for this in https://github.com/DandelionSprout/adfilt/commit/996d2e36ed0c0d1871f37545771c7fa4d0b30e37, but it is by no means a good idea in the long run.

Alex-302 avatar Aug 30 '21 14:08 Alex-302

I don't have Nordic Filters enabled, but the element picker popup doesn't show at all on website https://ylilauta.org/

matso167 avatar Aug 25 '22 13:08 matso167