AdGuardMV3 icon indicating copy to clipboard operation
AdGuardMV3 copied to clipboard

After adding some custom user rules I can't access the options.

Open 0c0d3 opened this issue 2 years ago • 33 comments

AdGuard MV3 0.3.17 Edge v.107.X Windows 11 Pro

Sin título Sin título2 Sin título3

0c0d3 avatar Nov 19 '22 10:11 0c0d3

@Mercyletter This can happen if you have added too large custom filter (e.g. about 200-300k rules). Can you attach the problematic custom filters? I will try to reproduce the error.

105th avatar Nov 19 '22 11:11 105th

customrules.txt I added them all together in the rule editor. Thank you very much. Best regards.

0c0d3 avatar Nov 19 '22 11:11 0c0d3

Do you have any news? Thank you very much. Best regards.

0c0d3 avatar Nov 21 '22 22:11 0c0d3

@Mercyletter tried to reproduce the problem - added these rules to the user rules section and everything is fine. Please check if there are any red errors in the chrome://extensions section under our extension?

Also, there are many rules with the modifier "$doc" - we don't support this modifier, you should replace it with "$document", I think.

105th avatar Nov 22 '22 07:11 105th

Any maybe should try to reinstall extension

105th avatar Nov 22 '22 07:11 105th

I still have the same problem after reinstalling the extension, after adding the user rules I tried to add a custom block list like this for example https://raw.githubusercontent.com/hagezi/dns-blocklists/main/adblock/pro.plus.txt and the extension does not open anymore.

What I basically did is: 1-Add the custom rules 2-Add block list 3-The extension stops working.

0c0d3 avatar Nov 22 '22 11:11 0c0d3

1 2

catch (e) { // TODO: Throw error exports.logger.info("Error: \"".concat(e.message, "\" in the rule: \"").concat(line, "\"")); } return null;

I'm not an expert, so I don't know if this will help. Thank you very much.

0c0d3 avatar Nov 22 '22 14:11 0c0d3

I still have the same problem after reinstalling the extension, after adding the user rules I tried to add a custom block list like this for example https://raw.githubusercontent.com/hagezi/dns-blocklists/main/adblock/pro.plus.txt and the extension does not open anymore.

What I basically did is: 1-Add the custom rules 2-Add block list 3-The extension stops working.

Hi,this list has too many rules. If you want to use custom lists with many rules, I recommend you to use NEXT DNS. You can insert these 2 lists:

https://github.com/Kees1958/W3C_annual_most_used_survey_blocklist/blob/master/addendum_to_Edge_Firefox_build_in.txt

https://raw.githubusercontent.com/uBlockOrigin/uAssets/master/filters/privacy.txt

SampeiNihira avatar Nov 24 '22 18:11 SampeiNihira

Thanks I have uninstalled and reinstalled I have also corrected the user rules and added the two lists you suggest here however the problem continues.

Sin título

0c0d3 avatar Nov 24 '22 19:11 0c0d3

Sin título2

0c0d3 avatar Nov 24 '22 19:11 0c0d3

@Mercyletter Good to hear you found a solution. To clarify what happened - we have a limit from Chrome on how many rules we can add to the extension: only 5,000 declarative rules for the dynamic section - custom rules and userrules. We're trying to increase the limit for dynamic rules from 5,000 to 30,000. Firefox and Safari seem to have supported this proposal, and now we're waiting a feedback from Chrome

But that 30,000 is still not enough for large custom filters, such as yours has about 440,000 rules.

And right now we don't have a limit on how many rules you can add to a custom filter, we're just reducing the conversion result to 5,000 rules - we'll fix that process in future releases.

And I'd like to add to the response from @SampeiNihira that you can try our AdGuard DNS blocking service or system ad blocker.

105th avatar Nov 25 '22 08:11 105th

@105th Hi, it is not fixed as you can see in the screenshots of my previous answers. Thank you very much. Best regards.

0c0d3 avatar Nov 25 '22 08:11 0c0d3

In the end I uninstalled the extension, reinstalled it, added a few rules and three filters and it seems to work fine. But it is quite annoying that there is no place for many rules I guess it will be part of MV3 and its consequences. Well, thank you all very much.

customrulesmv3.txt Sin título

0c0d3 avatar Nov 25 '22 09:11 0c0d3

@Mercyletter double checked the error from screenshots - it seems that the "can't start" problem has been solved in version 0.3.17.

But it is quite annoying that there is no place for many rules I guess it will be part of MV3 and its consequences.

I agree with you. That's why we're trying to increase the limit.

105th avatar Nov 25 '22 09:11 105th

@105th

If it were possible it would be interesting to enable, sooner rather than later, the

$removeparam

rule even though this has significant limitations as I have already been told.

gorhill in uBlock Origin Lite has already enabled the rule and included just your "AdGuard URL Tracking Protection" filter list. So I assume this is already possible.

I hope for a collaborative exchange of information.

SampeiNihira avatar Nov 25 '22 14:11 SampeiNihira

I have also experienced this issue in Edge by adding 3 custom lists with total rules less than 5000. To reproduce the issue please add these lists:

https://raw.githubusercontent.com/Kees1958/W3C_annual_most_used_survey_blocklist/master/addendum_to_Edge_Firefox_build_in.txt

https://raw.githubusercontent.com/uBlockOrigin/uAssets/master/filters/privacy.txt

https://raw.githubusercontent.com/uBlockOrigin/uAssets/master/filters/resource-abuse.txt

The 3 lists have a total number of 3092 rules.

There is a issue with the immediate display of the last added list.

There is a issue in the total display of dynamic rules tween adding the second list and after adding the third list. The number of dynamic rules decreases significantly.

SampeiNihira avatar Nov 26 '22 18:11 SampeiNihira

The extension stopped working after adding this small list. https://raw.githubusercontent.com/VernonStow/Filterlist/master/Filterlist.txt mv3

0c0d3 avatar Nov 29 '22 22:11 0c0d3

@105th Any news or update on this problem? Thank you very much. Best regards.

0c0d3 avatar Dec 11 '22 13:12 0c0d3

@SampeiNihira currently we have partial support of $removeparam rules with some limitations: Regexps, negation and allow-rules are not supported You can go to the documentation for more information - https://github.com/AdguardTeam/tsurlfilter/tree/epic/tswebextension/packages/tsurlfilter/src/rules/declarative-converter#removeparam-1

105th avatar Dec 12 '22 11:12 105th

@Mercyletter thanks for the reminder trying to repeat this error and can't reproduce, maybe this problem was solved in version 0.3.17. what version do you have?

105th avatar Dec 12 '22 11:12 105th

3 @105th Hi, only the second list I provided contains few $removeparam rules. This is a bug,which in my opinion,depends on the number of personal lists added.

If,on the other hand,you mean that when a list is added with $removeparam rules instead of being ignored they cause the extension to block. But it is still a bug.

SampeiNihira avatar Dec 12 '22 12:12 SampeiNihira

@105th I am using the latest version, the one you mention. Sin título Sin título ADMV3 ERRORS.txt

0c0d3 avatar Dec 12 '22 15:12 0c0d3

@105th Hi, were my error reports helpful, i.e. were you able to see what this specific error is about? Thank you very much. Best regards.

0c0d3 avatar Dec 16 '22 14:12 0c0d3

Maybe implementing https://github.com/AdguardTeam/AdguardForAndroid/issues/3916 for MV3 would help this kind of situation?

TPS avatar Dec 26 '22 20:12 TPS

Again the same error it seems that they could never reproduce it to correct it. I attached my anti-exploit settings maybe it will help something.

1 2 3 <?xml version="1.0" encoding="UTF-8"?> <MitigationPolicy> <SystemConfig> <ASLR ForceRelocateImages="true" RequireInfo="false" /> </SystemConfig> <AppConfig Executable="chrome.exe"> <DEP Enable="true" EmulateAtlThunks="false" /> <ASLR ForceRelocateImages="true" RequireInfo="false" BottomUp="true" HighEntropy="true" /> <ControlFlowGuard Enable="true" SuppressExports="false" /> <Fonts DisableNonSystemFonts="true" AuditOnly="false" Audit="false" /> <ImageLoad BlockRemoteImageLoads="true" AuditRemoteImageLoads="false" BlockLowLabelImageLoads="true" AuditLowLabelImageLoads="false" /> <SEHOP Enable="true" TelemetryOnly="false" /> <Heap TerminateOnError="true" /> <UserShadowStack UserShadowStack="true" UserShadowStackStrictMode="true" AuditUserShadowStack="false" /> </AppConfig> <AppConfig Executable="clview.exe"> <ASLR ForceRelocateImages="true" RequireInfo="false" /> </AppConfig> <AppConfig Executable="cnfnot32.exe"> <ASLR ForceRelocateImages="true" RequireInfo="false" /> </AppConfig> <AppConfig Executable="cscript.exe"> <SystemCalls DisableWin32kSystemCalls="true" Audit="false" /> </AppConfig> <AppConfig Executable="EQNEDT32.EXE"> <SystemCalls DisableWin32kSystemCalls="true" Audit="false" /> </AppConfig> <AppConfig Executable="excel.exe"> <ASLR ForceRelocateImages="true" RequireInfo="false" /> </AppConfig> <AppConfig Executable="excelcnv.exe"> <ASLR ForceRelocateImages="true" RequireInfo="false" /> </AppConfig> <AppConfig Executable="ExtExport.exe"> <ASLR ForceRelocateImages="true" RequireInfo="false" /> </AppConfig> <AppConfig Executable="findstr.exe"> <SystemCalls DisableWin32kSystemCalls="true" Audit="false" /> </AppConfig> <AppConfig Executable="firefox.exe"> <DEP Enable="true" EmulateAtlThunks="false" /> <ASLR ForceRelocateImages="true" RequireInfo="false" BottomUp="true" HighEntropy="true" /> <ControlFlowGuard Enable="true" SuppressExports="false" /> <Fonts DisableNonSystemFonts="true" AuditOnly="false" Audit="false" /> <ImageLoad BlockRemoteImageLoads="true" AuditRemoteImageLoads="false" BlockLowLabelImageLoads="false" /> <SEHOP Enable="true" TelemetryOnly="false" /> <Heap TerminateOnError="true" /> <UserShadowStack UserShadowStack="true" UserShadowStackStrictMode="true" AuditUserShadowStack="false" /> </AppConfig> <AppConfig Executable="graph.exe"> <ASLR ForceRelocateImages="true" RequireInfo="false" /> </AppConfig> <AppConfig Executable="ie4uinit.exe"> <ASLR ForceRelocateImages="true" RequireInfo="false" /> </AppConfig> <AppConfig Executable="ieinstal.exe"> <ASLR ForceRelocateImages="true" RequireInfo="false" /> </AppConfig> <AppConfig Executable="ielowutil.exe"> <ASLR ForceRelocateImages="true" RequireInfo="false" /> </AppConfig> <AppConfig Executable="ieUnatt.exe"> <ASLR ForceRelocateImages="true" RequireInfo="false" /> </AppConfig> <AppConfig Executable="iexplore.exe"> <ASLR ForceRelocateImages="true" RequireInfo="false" /> </AppConfig> <AppConfig Executable="msaccess.exe"> <ASLR ForceRelocateImages="true" RequireInfo="false" /> </AppConfig> <AppConfig Executable="mscorsvw.exe"> <ExtensionPoints DisableExtensionPoints="true" /> </AppConfig> <AppConfig Executable="msedge.exe"> <DEP Enable="true" EmulateAtlThunks="false" /> <ASLR ForceRelocateImages="true" RequireInfo="false" BottomUp="true" HighEntropy="true" /> <StrictHandle Enable="true" /> <ControlFlowGuard Enable="true" SuppressExports="false" /> <SignedBinaries EnforceModuleDependencySigning="true" /> <Fonts DisableNonSystemFonts="true" AuditOnly="false" Audit="false" /> <ImageLoad BlockRemoteImageLoads="true" AuditRemoteImageLoads="false" BlockLowLabelImageLoads="true" AuditLowLabelImageLoads="false" /> <SEHOP Enable="true" TelemetryOnly="false" /> <Heap TerminateOnError="true" /> <UserShadowStack UserShadowStack="true" UserShadowStackStrictMode="true" AuditUserShadowStack="false" /> </AppConfig> <AppConfig Executable="msfeedssync.exe"> <ASLR ForceRelocateImages="true" RequireInfo="false" /> </AppConfig> <AppConfig Executable="mshta.exe"> <ASLR ForceRelocateImages="true" RequireInfo="false" /> <SystemCalls DisableWin32kSystemCalls="true" Audit="false" /> </AppConfig> <AppConfig Executable="msoadfsb.exe"> <ASLR ForceRelocateImages="true" RequireInfo="false" /> </AppConfig> <AppConfig Executable="msoasb.exe"> <ASLR ForceRelocateImages="true" RequireInfo="false" /> </AppConfig> <AppConfig Executable="msohtmed.exe"> <ASLR ForceRelocateImages="true" RequireInfo="false" /> </AppConfig> <AppConfig Executable="msosrec.exe"> <ASLR ForceRelocateImages="true" RequireInfo="false" /> </AppConfig> <AppConfig Executable="msoxmled.exe"> <ASLR ForceRelocateImages="true" RequireInfo="false" /> </AppConfig> <AppConfig Executable="mspub.exe"> <ASLR ForceRelocateImages="true" RequireInfo="false" /> </AppConfig> <AppConfig Executable="msqry32.exe"> <ASLR ForceRelocateImages="true" RequireInfo="false" /> </AppConfig> <AppConfig Executable="MsSense.exe"> <StrictHandle Enable="true" /> <SEHOP Enable="true" TelemetryOnly="false" /> </AppConfig> <AppConfig Executable="ngen.exe"> <ExtensionPoints DisableExtensionPoints="true" /> </AppConfig> <AppConfig Executable="onenote.exe"> <ASLR ForceRelocateImages="true" RequireInfo="false" /> </AppConfig> <AppConfig Executable="onenotem.exe"> <ASLR ForceRelocateImages="true" RequireInfo="false" /> </AppConfig> <AppConfig Executable="orgchart.exe"> <ASLR ForceRelocateImages="true" RequireInfo="false" /> </AppConfig> <AppConfig Executable="outlook.exe"> <ASLR ForceRelocateImages="true" RequireInfo="false" /> </AppConfig> <AppConfig Executable="powerpnt.exe"> <ASLR ForceRelocateImages="true" RequireInfo="false" /> </AppConfig> <AppConfig Executable="PresentationHost.exe"> <DEP Enable="true" EmulateAtlThunks="false" /> <ASLR ForceRelocateImages="true" RequireInfo="false" BottomUp="true" HighEntropy="true" /> <SEHOP Enable="true" TelemetryOnly="false" /> <Heap TerminateOnError="true" /> </AppConfig> <AppConfig Executable="PrintDialog.exe"> <ExtensionPoints DisableExtensionPoints="true" /> </AppConfig> <AppConfig Executable="runas.exe"> <SystemCalls DisableWin32kSystemCalls="true" Audit="false" /> </AppConfig> <AppConfig Executable="scanost.exe"> <ASLR ForceRelocateImages="true" RequireInfo="false" /> </AppConfig> <AppConfig Executable="scanpst.exe"> <ASLR ForceRelocateImages="true" RequireInfo="false" /> </AppConfig> <AppConfig Executable="sdxhelper.exe"> <ASLR ForceRelocateImages="true" RequireInfo="false" /> </AppConfig> <AppConfig Executable="selfcert.exe"> <ASLR ForceRelocateImages="true" RequireInfo="false" /> </AppConfig> <AppConfig Executable="setlang.exe"> <ASLR ForceRelocateImages="true" RequireInfo="false" /> </AppConfig> <AppConfig Executable="SystemSettings.exe"> <ExtensionPoints DisableExtensionPoints="true" /> </AppConfig> <AppConfig Executable="winword.exe"> <ASLR ForceRelocateImages="true" RequireInfo="false" /> </AppConfig> <AppConfig Executable="wordconv.exe"> <ASLR ForceRelocateImages="true" RequireInfo="false" /> </AppConfig> <AppConfig Executable="wscript.exe"> <SystemCalls DisableWin32kSystemCalls="true" Audit="false" /> </AppConfig> </MitigationPolicy>

0c0d3 avatar Jan 08 '23 19:01 0c0d3

Sin título MV3 Errors.txt

0c0d3 avatar Jan 10 '23 10:01 0c0d3

@105th Hi, when will a new version be released?

ghost avatar Jan 16 '23 15:01 ghost

Currently, we are focused on the mv2 version. We will continue to work on mv3 later. In a month or two. Keep tuned.

maximtop avatar Jan 16 '23 17:01 maximtop

in Chrome Versión 111.0.5550.0 (Build oficial) canary (64 bits)

Sin título

0c0d3 avatar Jan 20 '23 22:01 0c0d3

Well, there is no point in continuing to comment here. I will look for an alternative to this extension. I close the issue. Thank you very much to all. All the best.

0c0d3 avatar Jan 21 '23 11:01 0c0d3